Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

fix: rename new helper executables #55

Merged
merged 1 commit into from
Aug 2, 2019
Merged

fix: rename new helper executables #55

merged 1 commit into from
Aug 2, 2019

Conversation

deepak1556
Copy link
Collaborator

Rename the following helper executables otherwise app would crash on start.

Electron Helper (Renderer)
Electron Helper (Plugin)
Electron Helper (Gpu)

Electron Helper (Renderer)
Electron Helper (Plugin)
Electron Helper (Gpu)
@deepak1556
Copy link
Collaborator Author

/cc @joaomoreno

@deepak1556 deepak1556 changed the title fix: account for new helper executables fix: rename new helper executables Jul 30, 2019
Copy link
Owner

@joaomoreno joaomoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't these parenthesis be optional? Won't this break current Electron versions?

@deepak1556
Copy link
Collaborator Author

deepak1556 commented Jul 31, 2019

The entire capture block is optional, so it should be fine. https://regex101.com/r/Vgn0Qf/2

@joaomoreno joaomoreno merged commit 0977c0f into joaomoreno:master Aug 2, 2019
@joaomoreno
Copy link
Owner

Published 1.22.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants