Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

fix: rename new helper executables #55

Merged
merged 1 commit into from
Aug 2, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/darwin.js
Original file line number Diff line number Diff line change
Expand Up @@ -263,17 +263,17 @@ function renameAppHelper(opts) {
var name = opts.productName;

return rename(function (path) {
var basenameMatch = /^Electron Helper( \w+)?$/.exec(path.basename);
var basenameMatch = /^Electron Helper( \(\w+\))?$/.exec(path.basename);

if (/Contents\/Frameworks/.test(path.dirname) && path.extname === '.app' && basenameMatch) {
var suffix = basenameMatch[1] || '';
path.basename = name + ' Helper' + suffix;
} else if (/Contents\/Frameworks\/Electron\ Helper( \w+)?\.app/.test(path.dirname)) {
var isInMacOS = /Contents\/Frameworks\/Electron\ Helper( \w+)?\.app\/Contents\/MacOS$/.test(path.dirname);
path.dirname = path.dirname.replace(/Electron\ Helper( \w+)?\.app/, name + ' Helper$1.app');
} else if (/Contents\/Frameworks\/Electron\ Helper( \(\w+\))?\.app/.test(path.dirname)) {
var isInMacOS = /Contents\/Frameworks\/Electron\ Helper( \(\w+\))?\.app\/Contents\/MacOS$/.test(path.dirname);
path.dirname = path.dirname.replace(/Electron\ Helper( \(\w+\))?\.app/, name + ' Helper$1.app');

if (isInMacOS && /^Electron Helper( \w+)?$/.test(path.basename) && path.extname === '') {
path.basename = path.basename.replace(/Electron\ Helper( \w+)?$/, name + ' Helper$1');
if (isInMacOS && /^Electron Helper( \(\w+\))?$/.test(path.basename) && path.extname === '') {
path.basename = path.basename.replace(/Electron\ Helper( \(\w+\))?$/, name + ' Helper$1');
}
}
});
Expand Down