Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu: focus indicator is not going the entire width #52911

Closed
bpasero opened this issue Jun 26, 2018 · 5 comments · Fixed by #53289
Closed

Menu: focus indicator is not going the entire width #52911

bpasero opened this issue Jun 26, 2018 · 5 comments · Fixed by #53289
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Jun 26, 2018

Refs: #52854

It looks like the focus indicator is only visible half width:

image

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug workbench-menu labels Jun 26, 2018
@chpxu
Copy link

chpxu commented Jun 26, 2018

The focus indicator is on by default, however shouldn't it be off, since most people will be using mice not the arrow keys, and then it will automatically appear once you use the keys? Also it isn't half-width on the "Tasks", "Help" menus, nor the gear in the bottom left.

@octref
Copy link
Contributor

octref commented Jun 26, 2018

Agreed - the focus indicator should include the whole label, and accessibility wise it should read over the Label + Shortcut.

@bpasero
Copy link
Member Author

bpasero commented Jun 28, 2018

@sbatten I am no longer seeing the focus indicator at all now, did something change?

image

@sbatten
Copy link
Member

sbatten commented Jun 29, 2018

@bpasero it seems the menu.css and shell.css get loaded in the opposite order in OSS which I don't know why, but that might be why you are not seeing it. It still repros in insiders. While I was figuring that out, I discovered that PR #53289 's fix actually addresses this issue as well as makes the screen reader read the keyboard shortcuts and mnemonics correctly. 🎉

@bpasero bpasero added this to the July 2018 milestone Jun 29, 2018
@bpasero
Copy link
Member Author

bpasero commented Jun 29, 2018

I commented.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants