-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Menu: focus indicator is not going the entire width #52911
Comments
The focus indicator is on by default, however shouldn't it be off, since most people will be using mice not the arrow keys, and then it will automatically appear once you use the keys? Also it isn't half-width on the "Tasks", "Help" menus, nor the gear in the bottom left. |
Agreed - the focus indicator should include the whole label, and accessibility wise it should read over the Label + Shortcut. |
@sbatten I am no longer seeing the focus indicator at all now, did something change? |
@bpasero it seems the menu.css and shell.css get loaded in the opposite order in OSS which I don't know why, but that might be why you are not seeing it. It still repros in insiders. While I was figuring that out, I discovered that PR #53289 's fix actually addresses this issue as well as makes the screen reader read the keyboard shortcuts and mnemonics correctly. 🎉 |
I commented. |
Refs: #52854
It looks like the focus indicator is only visible half width:
The text was updated successfully, but these errors were encountered: