Menu focus indicator full width (fix #52911)

[sbatten]

fix #52911 #53070

[bpasero]

@sbatten that change is a bit crazy because it makes changes to literally every action we have by moving the tabindex from the anchor element to the parent element. This will have implications on accessibility I fear.

I am not convinced this is the right solution only because the menu falls short. A better solution might be to look at the styling of the anchor element in the menu and maybe make that include the keybinding and span the full width. That would fix both this issue as well as the screen reader issue where the keybinding is not read. You could even have the anchor element have 2 additional elements (label, keybinding) and it would still work OK with a custom aria label. Since we now no longer accept a custom action item for the menus, we have the rendering under our control fully.

[bpasero]

Tested and seems to work fine 👍

[bpasero]

@sbatten one thing to keep in mind is that NVDA seems to announce the mnenmonic without the Alt key, just the letter.

[sbatten]

@bpasero that's the behavior you are seeing with these changes or what you would expect? On my machine, notepad + NVDA just says the letter, but VS Code + NVDA says Alt+ letter. I don't think either is wrong but using accesskey is what NVDA is using.

[bpasero]

@sbatten we can leave it but it might come back to us because we behave different from native menu