Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With custom titlebar, menus work quite differently from before #52285

Closed
yume-chan opened this issue Jun 19, 2018 · 2 comments
Closed

With custom titlebar, menus work quite differently from before #52285

yume-chan opened this issue Jun 19, 2018 · 2 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@yume-chan
Copy link
Contributor

Issue Type: Bug

Testing the new custom titlebar implementation (#51422)

image

  1. I just opened this menu, the first item now has keyboard focus. It used to require a Down Arrow to focus the first item. I think the current behavior is also reasonable and acceptable, just want to ask if it's intended.

However there is another minor display issue: the keyboard focus ring is too small. It should warp around the whole menu item, but now only the label part.

image

  1. Now I moved the keyboard focus to the second item, and hover my cursor on the first item. So now I have two focuses? I don't think a program should have a mouse focus and a keyboard focus simultaneously.

  2. Click "File" to open the menu, then click on "File" again, the menu should dismiss. It works most time, only except when I "click" via tapping on my Surface Pro's touch pad. It will quickly dismiss and reopen the menu.

image

  1. The check marks after the label look strange, why not display them in front of labels like most programs' menus?
@yume-chan yume-chan changed the title With custom titlebar, menus works quite differently from before With custom titlebar, menus work quite differently from before Jun 19, 2018
@sbatten
Copy link
Member

sbatten commented Jul 3, 2018

@yume-chan Thank you for your feedback. Though this issue was created very early, this item now exists broken up in several other issues. I am going to close this one for simplicity.

@sbatten sbatten closed this as completed Jul 3, 2018
@sbatten sbatten added the *duplicate Issue identified as a duplicate of another issue(s) label Jul 3, 2018
@sbatten
Copy link
Member

sbatten commented Jul 3, 2018

dupe of #52929, #52911, #52913, #52933

@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

3 participants