Testplan Item: Test refactor of notebook rich content search

[andreamah]

Refs #164926

• macOS @paulacamargo25
• linux @alexr00
• windows @rzhao271

Complexity: 3

Create Issue

---

Intro

The goal of this testplan items is to test showing rich content results when searching in OPEN notebooks.

I've had TPIs for this in the last two iterations (#174724, #177709), but I have refactored the structure of the notebook search code and have polished it a bit more. There haven't been any major feature changes since last endgame, but I just want a bit of a sanity check that everything still works.

I have explained this work in my last testplan item. If you're asking yourself questions like "what's rich content in notebooks?" or "what should I expect when I use the notebook toggle in search?", I'd advise you check out the intro section to my last testplan. :^)

Please enable the search.experimental.notebooksearch setting for this to work!

Tiny demo:

notebook-search.mp4

Testing

These items are pretty similar to last iteration's steps. Stuff marked (NEW) should get extra attention because they're new to this iteration

1. Open a workspace that has notebooks.
2. Test the new search functionality. You should see the "rich content" results appear when you:
   a. Open a notebook with search results, either from the explorer or from the search results itself.
   b. Perform a search and there are results in a currently opened notebook.
3. The results that are from read-only results should only have the x action button and not the replace one, even if the replace TextInput is visible.
4. You should see a toggle in the search input when you have a notebook open. This toggle should dictate what sort of results you get.
5. Closing the notebook with rich search content shouldn't affect the search results, and re-clicking the rich results should open the notebook at the correct places. However, if you re-search after closing the notebook, it will return to giving raw results.
6. Replace and Replace All functionalities should work, in addition to Dismiss for the results.
   a. When you replace all in a folder or workspace, the results for the read-only results (rendered markdown and code output) should persist
7. Dirty changes in notebooks that are open and have results in the search view should reflect in the search results.
8. Results should be properly highlighted when you open the file. Jumping to a result when clicking on it should work.
9. (NEW) Clicking the x on a result should remove its search result highlight (highlight is orange on default dark theme). Note that this only works for code inputs and markdown inputs, as outputs/markdown preview need extra work to remove highlights (notebook search: output matches not disappearing when dismissed  #179915).
10. (NEW) Opening search results with rich content matches in the search editor by clicking "Open in editor" should work and show results for editable cells (code input and markdown input cells).
11. Setting the experimental flag to false will restore search to its default behavior.

Big + persistent known bugs:

• files with no replaceable results still have a replace button.
• no diff editor for notebook search
• webview highlights persist after being dismissed

Since I'll be oof when testing occurs, please contact @roblourens if you have any questions! (but please assign all issues to me to address when I'm back)