Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace all on file shall not be shown if none of the matches support replace #177808

Closed
sandy081 opened this issue Mar 21, 2023 · 2 comments · Fixed by #182113
Closed

Replace all on file shall not be shown if none of the matches support replace #177808

sandy081 opened this issue Mar 21, 2023 · 2 comments · Fixed by #182113
Assignees
@andreamah
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook search Search widget and operation issues verified Verification succeeded
Milestone
May 2023

Comments

@sandy081
Copy link
Member

Testing #177709

image
@andreamah andreamah added this to the April 2023 milestone Mar 22, 2023
@andreamah andreamah added bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues notebook labels Mar 22, 2023
@andreamah andreamah mentioned this issue Apr 13, 2023
Closed
3 tasks
@andreamah andreamah modified the milestones: April 2023, May 2023 Apr 14, 2023
@andreamah andreamah mentioned this issue May 10, 2023
Merged
andreamah added a commit that referenced this issue May 10, 2023
@andreamah
Replace all on file shall not be shown if none of the matches support…
2e10d49 
… replace

Fixes #177808
andreamah added a commit that referenced this issue May 11, 2023
@andreamah
Replace all on file shall not be shown if none of the matches support…
637b293 
… replace (#182113)

* Replace all on file shall not be shown if none of the matches support replace
Fixes #177808
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 11, 2023
@rzhao271 rzhao271 added the verified Verification succeeded label May 31, 2023
@rzhao271
Copy link
Contributor

The file-specific button is gone, but I'm wondering whether the general Replace All button next to the replace inputbox can also be disabled? Otherwise I can do the following:

  1. Open a GitHub Issues Notebook.
  2. Search for a string specifically only in the output. Add a string in the replace inputbox.
  3. Press the replace all button.
  4. 🐛 It claims that it was able to replace the string.

The file-specific button is gone, but there's still an enabled Replace All button

@andreamah andreamah mentioned this issue Jun 1, 2023
Open
@andreamah
Copy link
Contributor

created issue for it in #184081

@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@andreamah andreamah

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook search Search widget and operation issues verified Verification succeeded
Projects
None yet
Milestone
May 2023
Development

Successfully merging a pull request may close this issue.

Replace all on file shall not be shown if none of the matches support replace microsoft/vscode
4 participants
@rzhao271 @sandy081 @andreamah @vscodenpa