Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create options for performing global search that includes rendered and outputted notebook content #164926

Closed
andreamah opened this issue Oct 28, 2022 · 3 comments · Fixed by #173978
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan search Search widget and operation issues
Milestone

Comments

@andreamah
Copy link
Contributor

Continuation of #148068

With the notebook editors binded to the search model, we can explore adding filter options for rendered markdown and output like there is in the notebook find widget.

image

I tentatively think that it would be through a filter icon that only appears when notebooks are binded, but there might be a better way of showing this.

image

@andreamah andreamah added feature-request Request for new features or functionality search Search widget and operation issues labels Oct 28, 2022
@andreamah andreamah added this to the On Deck milestone Oct 28, 2022
@andreamah andreamah self-assigned this Oct 28, 2022
@Okaretkina7

This comment was marked as spam.

@andreamah
Copy link
Contributor Author

This issue will also cover searching dirty changes in the notebook editor, for read-only and editable content.

@andreamah
Copy link
Contributor Author

will likely go with this type of format for switching between match types (cell input, cell output, rendered/output markdown)
image

@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan search Search widget and operation issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants