Markdown "code cell source" still being searched even when toggled off

[alexr00]

Testing #179922

1. Open clone of this repo in VS Code
2. Open the my-endgame.github-issues notebook
3. Run some queries from the notebook
4. Change the toggles in the search filter so that "Code Cell Source" is toggled off and "Code Cell Output" is toggled on.
5. Search for "microsoft/vscode"
6. ✅ See correct results for my-endgame.github-issues
7. However, the results for inbox.github-issues include markdown code cell source

[andreamah]

To get the filters to apply, we currently require the notebook to be opened. So it makes sense that inbox.github-issues would just search the raw ipynb json text. Does it make sense via that context?

[alexr00]

It's a little confusing from a user perspective, but I can understand from a technical perspective why it works that way.

[andreamah]

We're currently working on getting this search to work on closed notebooks (#173726). Hopefully, from that, we can get a better user experience with this. I'm gonna close this now, since improving this experience should be part of the closed notebook search work.