Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Surface environment variable information in hover, even when not stale #177078

Closed
Tracked by #20822
Tyriar opened this issue Mar 14, 2023 · 1 comment · Fixed by #177085
Closed
Tracked by #20822

Surface environment variable information in hover, even when not stale #177078

Tyriar opened this issue Mar 14, 2023 · 1 comment · Fixed by #177085
Assignees
@Tyriar @meganrogge
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan terminal-tabs
Milestone
March 2023

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 14, 2023

Currently when a terminal environment is "stale" we show messages here:

image

And here:

image

We have wanted to remove the latter as part of #151160.

Something I've always wanted since this was added was to surface existing environment variable contributions here as well and the upcoming description API (#171108) will make this a lot nicer. For example, the git extension could explain that it's contributing an authentication provider instead of a bunch of mysterious environment variables.
@Tyriar Tyriar added feature-request Request for new features or functionality terminal-tabs labels Mar 14, 2023
@Tyriar Tyriar added this to the March 2023 milestone Mar 14, 2023
@Tyriar
Copy link
Member Author

Tyriar commented Mar 14, 2023

cc @karrtikr

Tyriar added a commit that referenced this issue Mar 14, 2023
@Tyriar
Show env changes in tab, remove widget
f41c665 
Part of #151160
Part of #177078
This was referenced Mar 14, 2023
Merged
Closed
@karrtikr karrtikr mentioned this issue Mar 14, 2023
Closed
22 tasks
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Mar 15, 2023
@Tyriar Tyriar mentioned this issue Mar 20, 2023
Closed
3 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan terminal-tabs
Projects
None yet
Milestone
March 2023
Development

Successfully merging a pull request may close this issue.

Remove env var info widget and surface info in terminal tab microsoft/vscode
3 participants
@Tyriar @meganrogge @vscodenpa