Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove env var indicator from terminal #151160

Closed
joyceerhl opened this issue Jun 2, 2022 · 3 comments · Fixed by #177085
Closed

remove env var indicator from terminal #151160

joyceerhl opened this issue Jun 2, 2022 · 3 comments · Fixed by #177085
Assignees
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue terminal-process Problems launching processes, managing ptys, exiting, process leaks, etc.
Milestone

Comments

@joyceerhl
Copy link
Contributor

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.68-insider
  • OS Version: Windows 11

Steps to Reproduce:

  1. Have some task for which shell integration fails to activate
  2. 🐛 warning icon is rendered on top of task output
    image
@Tyriar
Copy link
Member

Tyriar commented Jun 2, 2022

@joyceerhl if you hover that does it talk about environment variables? I didn't think we mentioned shell integration there

@Tyriar Tyriar added the info-needed Issue requires more information from poster label Jun 2, 2022
@joyceerhl
Copy link
Contributor Author

Oh sorry you're right, it just talks about environment variables (I reproed this by revoking trust for my workspace and then launching tasks). I also saw #151163 which is why I mentioned shell integration. Still I wouldn't expect the warning icon to overlay the task output.

@Tyriar
Copy link
Member

Tyriar commented Jun 3, 2022

This is typically only an issue for very narrow terminals and has been like this for a long time, it's actually come up before when the feature first came out. It's essentially deprecated now and will probably be removed soon, I don't think that's tracked anywhere so we can evaluate removing it in June.

@Tyriar Tyriar added polish Cleanup and polish issue terminal-process Problems launching processes, managing ptys, exiting, process leaks, etc. and removed info-needed Issue requires more information from poster labels Jun 3, 2022
@Tyriar Tyriar added this to the June 2022 milestone Jun 3, 2022
@meganrogge meganrogge changed the title "Shell integration failed to activate" warning icon appears on top of task content remove env var indicator from terminal Jun 14, 2022
@meganrogge meganrogge modified the milestones: June 2022, July 2022 Jun 14, 2022
@meganrogge meganrogge added the debt Code quality issues label Jun 14, 2022
@Tyriar Tyriar modified the milestones: July 2022, Backlog Jul 5, 2022
@Tyriar Tyriar modified the milestones: Backlog, January 2023 Dec 12, 2022
@Tyriar Tyriar modified the milestones: January 2023, Backlog Jan 6, 2023
Tyriar added a commit that referenced this issue Mar 14, 2023
@Tyriar Tyriar modified the milestones: Backlog, March 2023 Mar 15, 2023
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Mar 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue terminal-process Problems launching processes, managing ptys, exiting, process leaks, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants