Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to provide description to environment collection API #171108

Closed
Tracked by #20822
karrtikr opened this issue Jan 11, 2023 · 19 comments · Fixed by #184370
Closed
Tracked by #20822

Allow to provide description to environment collection API #171108

karrtikr opened this issue Jan 11, 2023 · 19 comments · Fixed by #184370
Assignees
Labels
api api-finalization feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal-process Problems launching processes, managing ptys, exiting, process leaks, etc. ux User experience issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@karrtikr
Copy link
Contributor

karrtikr commented Jan 11, 2023

Particularly for the Python environments, the list of environment vars can be long, hence the prompt which shows up can be too verbose:

image

It would be perhaps more helpful if we can provide a simple description instead of the exact changes.

cc/ @Tyriar

@karrtikr
Copy link
Contributor Author

This could also be extended to show up as terminal.title the first time the terminal is relaunched. Fish shell does not have a prompt variable which we could set like cmd to indicate which environment is active, which could also make use of this feature:

image

@Tyriar Tyriar assigned Tyriar and meganrogge and unassigned aeschli Jan 12, 2023
@Tyriar Tyriar added ux User experience issues feature-request Request for new features or functionality api terminal-process Problems launching processes, managing ptys, exiting, process leaks, etc. labels Jan 12, 2023
@Tyriar Tyriar added this to the Backlog milestone Jan 12, 2023
@Tyriar
Copy link
Member

Tyriar commented Mar 7, 2023

Proposal:

#171108

export interface EnvironmentVariableCollection extends Iterable<[variable: string, mutator: EnvironmentVariableMutator]> {
	/**
	 * A description for the environment variable collection, this will be used to describe the
	 * changes in the UI.
	 */
	description: string | undefined;
}

We probably still want a way to show the actual environment variable changes even with this description though.

@meganrogge
Copy link
Contributor

It would be nice if there were a View Changes action that opened a readonly editor with the changes. That would make it very accessible

@Tyriar
Copy link
Member

Tyriar commented Mar 7, 2023

@meganrogge I was thinking a button in the hover to toggle it, but I like your suggestion more

@Tyriar Tyriar modified the milestones: Backlog, March 2023 Mar 7, 2023
@Tyriar
Copy link
Member

Tyriar commented Mar 7, 2023

Feedback from API sync: Add MarkdownString

@jrieken
Copy link
Member

jrieken commented May 10, 2023

@Tyriar @karrtikr Looks like #179476, #171173, and #171108 are all very closely related. For a holistic view at the changes a single discussion/issue/proposal might be more beneficial.

@Tyriar
Copy link
Member

Tyriar commented May 10, 2023

@jrieken created: #182069

@karrtikr
Copy link
Contributor Author

Closing in favor of #182069 as these issues were only open to finalize proposed API.

@Tyriar
Copy link
Member

Tyriar commented May 10, 2023

@karrtikr they're all separate proposals, let's keep them open and have #182069 for a holistic view

@Tyriar
Copy link
Member

Tyriar commented Jun 5, 2023

I'm planning on finalizing this one independently of the workspace scope one this iteration.

@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 5, 2023
@Tyriar Tyriar added the verification-needed Verification of issue is requested label Jun 26, 2023
@Tyriar
Copy link
Member

Tyriar commented Jun 26, 2023

To verify make sure the API shows up in the stable API and does not have a proposed check.

@DonJayamanne
Copy link
Contributor

Tried this, not sure what I need to do to get this to work
I just updated the description property in the context.environmentVariableCollection and created a new terminal and nothing seems to be displayed.
@Tyriar Am i missing a step here?

@jrieken jrieken added the verified Verification succeeded label Jun 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api api-finalization feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal-process Problems launching processes, managing ptys, exiting, process leaks, etc. ux User experience issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants