Recalculate quake window size when snapping across monitors #10744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into dev/migrie/b/snapping-quake-window
…a smaller size. Maybe we shouldn't SetWindowPos in WM_WINDOWPOSCHANGING at all?
ghost
added
Area-User Interface
DHowett
approved these changes
Jul 21, 2021
Co-authored-by: Dustin L. Howett <duhowett@microsoft.com>
zadjii-msft
added
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
requested review from
miniksa,
carlos-zamora,
leonMSFT,
PankajBhojwani and
lhecker
lhecker
reviewed
Jul 22, 2021
Comment on lines
547
to
548
| if (til::rectangle{ proposedInfo.rcMonitor } != | ||
| til::rectangle{ currentInfo.rcMonitor }) |
There was a problem hiding this comment.
I don't believe you have to wrap these structs first. You should be able to compare them directly.
There was a problem hiding this comment.
Uhg, it doesn't let me do that 😕 I didn't really feel like manually comparing each of .left, .top, etc, and this isn't going to be a particularly hot path
There was a problem hiding this comment.
Oh I just wrote it because I thought it might make the code simpler. ^^
lhecker
approved these changes
Aug 2, 2021
DHowett
pushed a commit
that referenced
this pull request
Aug 25, 2021
## Summary of the Pull Request <kbd>win+shift+arrows</kbd> can be used to move windows to adjacent monitors. When that happens, we'll new re-calculate the size of the window for the new monitor. ## References * megathread: #8888 ## PR Checklist * [x] Closes #10274 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments In `WM_WINDOWPOSCHANGING`, the OS says "hey, I'm about to do {something} to your window. You cool with that?". We handle that message by: 1. checking if the window was _moved_ as a part of this message 2. getting the monitor that the window will be moved onto 3. If that monitor is different than the monitor the window is currently on, then * calculate how big the quake window should be on that monitor * tell the OS that's where we'd like to be. ## Validation Steps Performed * <kbd>win+shift+arrows</kbd> works right now * normal quake summoning still works right
|
🎉 Handy links: |
ghost
mentioned this pull request
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
win+shift+arrows can be used to move windows to adjacent monitors. When that happens, we'll new re-calculate the size of the window for the new monitor.
References
PR Checklist
Detailed Description of the Pull Request / Additional comments
In
WM_WINDOWPOSCHANGING, the OS says "hey, I'm about to do {something} to your window. You cool with that?". We handle that message by:Validation Steps Performed