Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quake mode doesn't scale width when changing monitor size #11125

Open
Tracked by #8888
benjamincburns opened this issue Sep 3, 2021 · 10 comments
Open
Tracked by #8888

Quake mode doesn't scale width when changing monitor size #11125

benjamincburns opened this issue Sep 3, 2021 · 10 comments
Labels
Area-Windowing Window frame, quake mode, tearout Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Milestone

Comments

@benjamincburns
Copy link

benjamincburns commented Sep 3, 2021

Windows Terminal version (or Windows build number)

1.11.2421.0

Other Software

Windows 10 20H2 build 19042.1165

Steps to reproduce

  1. Start Windows Terminal while using wider monitor on laptop dock and open quake window
  2. Unplug laptop from dock
  3. Show the quake window (may not be necessary)
  4. Hide the quake window (may not be necessary)
  5. Plug back into dock
  6. Show the quake window

Expected Behavior

When I plug back into my external monitor I'd expect the width of the quake window to fit the width of the monitor, or at the very least, to be able to resize the quake window horizontally to make this be the case.

Actual Behavior

The quake window stays sized to the narrower monitor, even after switching back to a wider monitor (see screenshot below).

image

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Sep 3, 2021
@benjamincburns
Copy link
Author

Not sure if this is related to #10515, but it looks (very) loosely similar, so mentioning it just in case.

@DHowett
Copy link
Member

DHowett commented Sep 3, 2021

Ah, would you mind updating to the latest version?

@DHowett DHowett added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Sep 3, 2021
@benjamincburns
Copy link
Author

@DHowett this is still a problem on 1.11.2421.0 - I'll update the version info in my description.

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Sep 3, 2021
@DHowett
Copy link
Member

DHowett commented Sep 3, 2021

Thank you! 🙂

@b-hayes
Copy link

b-hayes commented Sep 3, 2021

Did this just get fixed in #10744 ?

@zadjii-msft
Copy link
Member

This does look like #10744, but that one was fixed in v1.11.2421.0. Presumably we don't get a WM_WINDOWPOSCHANGING in this scenario, maybe we get some other message.

@zadjii-msft zadjii-msft added Area-Windowing Window frame, quake mode, tearout Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. and removed Needs-Attention The core contributors need to come back around and look at this ASAP. labels Sep 8, 2021
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Sep 8, 2021
@b-hayes
Copy link

b-hayes commented Sep 8, 2021

Might also pay to check when UI scaling changes for the current screen. Bit of an edge case I probably change mine more often than most.

@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Oct 15, 2021
@zadjii-msft zadjii-msft modified the milestones: Terminal v2.0, 22H2 Jan 4, 2022
@zadjii-msft zadjii-msft removed the Needs-Tag-Fix Doesn't match tag requirements label Mar 30, 2022
@CherryDT
Copy link

I encounter this issue now too. My situation is as follows: When I connect my external screen, the internal screen becomes the secondary screen and has a lower resolution. Now I had the external screen connected and then disconnected again and now the window doesn't have the full width anymore.

@zadjii-msft zadjii-msft removed this from the 22H2 milestone Dec 5, 2022
@zadjii-msft zadjii-msft added this to the Backlog milestone Dec 5, 2022
@Uxorious
Copy link

Uxorious commented Oct 6, 2023

This is still an issue btw.

@zadjii-msft
Copy link
Member

I believe there's a 99% chance this will be fixed when we do the SPI_WORKAREA thing from #16067

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Windowing Window frame, quake mode, tearout Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

6 participants