Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GVFS Helper] Fix parallel load test #156

Closed
derrickstolee opened this issue Oct 4, 2019 · 1 comment · Fixed by #157
Closed

[GVFS Helper] Fix parallel load test #156

derrickstolee opened this issue Oct 4, 2019 · 1 comment · Fixed by #157
Assignees
@derrickstolee
Labels
bug correctness issues
Milestone
MVP

Comments

@derrickstolee
Copy link
Contributor

derrickstolee commented Oct 4, 2019 •
edited
Loading

@wilbaker noted in #122 that I had changed the parallel test to git rev-list --objects HEAD^{tree} and should not have. This makes the test do nothing of value: we already loaded all blobs at HEAD due to the non-sparse clone. (If we made the test do a sparse clone, then that would be interesting.)

However, without that change we get test failures in ParallelDownloadsInSharedCache().

After investigating, I think we have a different race condition that we didn't see before.
@derrickstolee derrickstolee added the bug correctness issues label Oct 4, 2019
@derrickstolee derrickstolee added this to the MVP milestone Oct 4, 2019
@derrickstolee derrickstolee self-assigned this Oct 4, 2019
@derrickstolee derrickstolee mentioned this issue Oct 4, 2019
Merged
@derrickstolee
Copy link
Contributor Author

I got the tests to pass locally on my Mac with the fix in microsoft/git#205.

@derrickstolee derrickstolee mentioned this issue Oct 4, 2019
Merged
derrickstolee added a commit that referenced this issue Oct 5, 2019
@derrickstolee
Merge pull request #157: Update Git to include race condition fix in …
7d437dc 
…gvfs-helper

Resolves #156.

See microsoft/git#205 for the Git code change. One race condition still existed: who creates the loose object _directory_ first? The simple change is to check if the directory exists after the mkdir fails.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derrickstolee derrickstolee

Labels
bug correctness issues
Projects
None yet
Milestone
MVP
Development

Successfully merging a pull request may close this issue.

Update Git to include race condition fix in gvfs-helper
1 participant
@derrickstolee