Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanups following gvfs-helper #150

Merged
merged 3 commits into from
Oct 4, 2019
Merged

Cleanups following gvfs-helper #150

merged 3 commits into from
Oct 4, 2019

Conversation

derrickstolee
Copy link
Contributor

Here are a few leftovers from #71

  • There were a few more "readobject" strings in the codebase.

  • The PackfileMaintenanceStepTests were disabled, but now they are re-enabled and adjusted to the new gvfs-helper environment.

  • The PrefetchVerb no longer does anything but the commits and trees prefetch, so drop the --commits option.

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
@derrickstolee derrickstolee added this to the MVP milestone Oct 4, 2019
@wilbaker
Copy link
Member

wilbaker commented Oct 4, 2019

@derrickstolee unrelated to these specific changes, I saw that this change:

It's not! I thought it would speed up the test, but in fact it makes the test do nothing of value. I'll remove this and try the speed-up later (while also making these enlistments sparse).

I'll drop it from this PR.

Did end up getting merged in as part of #122, was that intentional? If not, should it get backed out in this PR?

@derrickstolee
Copy link
Contributor Author

derrickstolee commented Oct 4, 2019

It's not! I thought it would speed up the test, but in fact it makes the test do nothing of value. I'll remove this and try the speed-up later (while also making these enlistments sparse).

I'll drop it from this PR.

Did end up getting merged in as part of #122, was that intentional? If not, should it get backed out in this PR?

Thanks for catching that, @wilbaker! I definitely thought I had changed that, but must have forgotten. I'll get it in this one.

@derrickstolee
Copy link
Contributor Author

I removed the test change as it broke the build. I filed #156 to track fixing that test.

@derrickstolee derrickstolee merged commit a3613f8 into microsoft:master Oct 4, 2019
@derrickstolee derrickstolee deleted the gvfs-helper-cleanups branch November 18, 2019 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants