Skip to content

Commit

Permalink
Merge pull request #157: Update Git to include race condition fix in …
Browse files Browse the repository at this point in the history
…gvfs-helper

Resolves #156.

See microsoft/git#205 for the Git code change. One race condition still existed: who creates the loose object _directory_ first? The simple change is to check if the directory exists after the mkdir fails.
  • Loading branch information
derrickstolee authored Oct 5, 2019
2 parents a3613f8 + 6340637 commit 7d437dc
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Scalar.Build/Scalar.props
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

<PropertyGroup Label="Parameters">
<ScalarVersion>0.2.173.2</ScalarVersion>
<GitPackageVersion>2.20191003.3-sc</GitPackageVersion>
<GitPackageVersion>2.20191004.2-sc</GitPackageVersion>
</PropertyGroup>

<PropertyGroup Label="DefaultSettings">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ private void LoadBlobsViaGit(ScalarFunctionalTestEnlistment enlistment)
{
// 'git rev-list --objects' will check for all objects' existence, which
// triggers an object download on every missing blob.
ProcessResult result = GitHelpers.InvokeGitAgainstScalarRepo(enlistment.RepoRoot, "rev-list --objects HEAD^{tree}");
ProcessResult result = GitHelpers.InvokeGitAgainstScalarRepo(enlistment.RepoRoot, "rev-list --all --objects");
result.ExitCode.ShouldEqual(0, result.Errors);
}
}
Expand Down

0 comments on commit 7d437dc

Please sign in to comment.