Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace uses of "UseAsPressable" with "usePressableState" #1035

Closed
Saadnajmi opened this issue Sep 27, 2021 · 1 comment · Fixed by #2154, #2156, #2155, #2153 or #2147
Closed

Replace uses of "UseAsPressable" with "usePressableState" #1035

Saadnajmi opened this issue Sep 27, 2021 · 1 comment · Fixed by #2154, #2156, #2155, #2153 or #2147
Labels
Area: Framework Priority: Normal Status: Fixed Type: Cleanup

Comments

@Saadnajmi
Copy link
Collaborator

Per this discussion in #863 , we should replace all of our uses of "useAsPressable" / View slots with "usePressableState" / Pressable slots.

As of the time of writing, here are all the things that use that hook:

  • Button
  • Checkbox
  • ContextualMenu
  • Link
  • RadioButton
  • Tabs / TabItem
@ghost ghost added the Needs: Triage 🔍 label Sep 27, 2021
@rurikoaraki rurikoaraki added Type: New Feature New feature or request and removed Needs: Triage 🔍 labels Sep 27, 2021
This was referenced Oct 12, 2021
Merged
Closed
@Saadnajmi
Copy link
Collaborator Author

Upstream issues to get fixed before we can finish this work:
microsoft/react-native-windows#8972
microsoft/react-native-macos#871

@rurikoaraki rurikoaraki mentioned this issue Dec 14, 2021
Merged
10 tasks
@Saadnajmi Saadnajmi mentioned this issue Sep 22, 2022
Merged
10 tasks
@ghost ghost added the Status: In PR label Sep 22, 2022
This was referenced Sep 22, 2022
Merged
Merged
Merged
Merged
Merged
@ghost ghost added Status: Fixed and removed Status: In PR labels Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Framework Priority: Normal Status: Fixed Type: Cleanup
Projects
None yet
Milestone
No milestone
2 participants
@rurikoaraki @Saadnajmi