Switch Menu components to Pressable #2147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…native into pressable-menu
|
This one will probably need to wait on both the RN 0.68 bump and the new next DefinitelyTyped package to update so we can get the over props with out TS yelling at us. Otherwise I can suppress the TS errors temporarily. |
10 tasks
Saadnajmi
changed the title
|
I think the CI errors can be fixed after #2157 merges |
rurikoaraki
reviewed
Sep 22, 2022
Saadnajmi
changed the title
|
"Tested that hover/focus/press still work on macOS ContextualMenu." --> can you expand your description on your test cases here? keyboard accessibility, screenreader etc. |
Updated with notes about VoiceOver and keyboard accessibility. |
rurikoaraki
approved these changes
Oct 18, 2022
lawrencewin
pushed a commit
to lawrencewin/fluentui-react-native
that referenced
this pull request
Oct 18, 2022
* Switch Menu components to use React Native Pressable * Change files * Update slots and snapshots * Use PressablePropsExtended * MenuItem*Info * Fix ci * snapshot * Update disabled behavor handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Helps to resolve #1035
Back in RN 0.62, we forked RN Core's Pressable, with the intention of eventually removing that fork. We've gone through the effort of updating React Native Core, Windows, Win32, macOS, and the DefinitelyTyped types to make sure that the upstream pressable supports all the hover/focus/press states and types we need. Let's complete this work by replacing our components one by one with Pressable.
Specifically, we should replace references of "useAsPressable" (which uses our fork) with "usePressableState" (which is designed to work with React Native's Pressable.
Verification
Tested that hover/focus/press still work on macOS ContextualMenu.
Tested that Menu items and disabled menu items are read correctly by VoiceOver
Tested that keyboarding accessibility still behaves as expected
Pull request checklist
This PR has considered (when applicable):