Update Button Documentation #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rurikoaraki
commented
Dec 14, 2021
| /** | ||
| * A callback to call on button click event | ||
| */ | ||
| onClick?: () => void; |
There was a problem hiding this comment.
This should change to onPress in the long run per #1035
rurikoaraki
commented
Dec 14, 2021
| @@ -87,18 +89,18 @@ export type ButtonProps = Omit<IWithPressableOptions<ViewProps>, 'onPress'> & { | |||
| */ | |||
| block?: boolean; | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Comes as part of RN View props
rurikoaraki
commented
Dec 14, 2021
| @@ -91,7 +92,9 @@ export interface ButtonCorePropsWithInnerRef extends Omit<IWithPressableOptions< | |||
| */ | |||
| onClick?: () => void; | |||
|
|
|||
| testID?: string; | |||
There was a problem hiding this comment.
Comes as part of RN View props
rurikoaraki
commented
Dec 14, 2021
| @@ -76,6 +76,7 @@ export interface ButtonTokens extends ButtonCoreTokens { | |||
| export interface ButtonCorePropsWithInnerRef extends Omit<IWithPressableOptions<ViewProps>, 'onPress'> { | |||
| /* | |||
| * Text to show on the Button. | |||
| * Only used in FAB | |||
There was a problem hiding this comment.
Should be removed soon, so just going to leave this comment instead making a whole type for it.
chiuam
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Updating documentation for base button
Verification
Build succeeds
Pull request checklist
This PR has considered (when applicable):