Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose onHoverIn/onHoverOut on Pressable #8972

Closed
Saadnajmi opened this issue Oct 27, 2021 · 7 comments · Fixed by #9066
Closed

Expose onHoverIn/onHoverOut on Pressable #8972

Saadnajmi opened this issue Oct 27, 2021 · 7 comments · Fixed by #9066
Assignees
Milestone

Comments

@Saadnajmi
Copy link
Contributor

Summary

With facebook/react-native#32405 , The Stock Pressable component now exposes onHoverIn/onHoverOut as the way to support mouse events. We should align our desktop ports (rn-macos/windows/win32) to take advantage of this.

Motivation

This issue is motivated by my want to use the RN Stock Pressable component in FluentUI React Native, which currently has a local copy of Pressable internally. Using the upstream component would mean less custom code and smaller bundle size for FluentUI React Native. It also will help push Pressable as "the" cross platform component for handling mouse / keyboard focus / press events.

Basic Example

No response

Open Questions

No response

@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Oct 27, 2021
@Saadnajmi
Copy link
Contributor Author

Similar macOS issue: microsoft/react-native-macos#871

@chrisglein chrisglein added Area: Mouse and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Oct 28, 2021
@chrisglein chrisglein added this to the 0.68 milestone Oct 28, 2021
@rectified95
Copy link
Contributor

This is going to be pulled in as part of the next RN integration we do. We are currently at Oct 21st, and the change in question was merged on Oct 23rd. @NickGerleman is probably going to pull this in within a week or so.

@NickGerleman
Copy link
Collaborator

@rectified95 you and @chiaramooney are on rotation for November 🙂.

@rectified95
Copy link
Contributor

That is very true :D

@Saadnajmi
Copy link
Contributor Author

If I read the updates to this bug properly, the upstream change will be merged in ~ next week, and will land with RN 0.68?
Is there any chance we can back port it to RN 0.64? I would like to get the same change in RN-macOS so FURN (which should soon move to RN 0.64) could potentially use it across macOS/windows/win32

@acoates-ms
Copy link
Contributor

Very unlikely, FB generally doesn't backport features to older versions.

@Saadnajmi
Copy link
Contributor Author

Very unlikely, FB generally doesn't backport features to older versions.

Sorry, I meant RN-Windows 0.64, not RN Core

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants