Expose Pressability Hover config props in Pressable

[Saadnajmi]

Summary

Several desktop forks (react-native-macos, react-native-windows, react-native-web) support mouse events, and while the stock Pressable component has the ability to support mouse events, it seems we aren't forwarding some props properly from Pressable -> Pressability.

Pressability will calculate onMouseEnter / onMouseLeave event handlers based on the onHoverIn/onHoverOut callbacks passed into PressabilityConfig.

react-native/Libraries/Pressability/Pressability.js

Line 552 in ad0d453

const mouseEventHandlers =

However, Pressable does not pass take in onHoverIn/onHoverOut props to pass to PressabilityConfig, so we can't take advantage of this functionality. This change should simply address that by passing the props through.

Changelog

[General] [Fixed] - Pressable not passing hover props and event handlers to PressabilityConfig

Test Plan

I fixed a similar issue in react-native-macos that I am now trying to contribute back upstream. microsoft#855

[analysis-bot]

Code analysis results:

• eslint found some issues. Run yarn lint --fix to automatically fix problems.

[pull-bot]

PR build artifact for f516aab is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 689bfed

[NickGerleman]

I think Pressability will test against running on react-native-web before processing onMouseEnter, etc for hover. Would make sense to make that generic if exposing I think.

[Saadnajmi]

I think Pressability will test against running on react-native-web before processing onMouseEnter, etc for hover. Would make sense to make that generic if exposing I think.

Do you basically mean, removing this check?

react-native/Libraries/Pressability/HoverState.js

Line 15 in b2e6483

if (Platform.OS === 'web') {

Note for others: we override this check in react-native-macos to return true if the platform is macOS. I'm sure other platforms do something similar

[facebook-github-bot]

@sota000 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@sota000 merged this pull request in 1b30dd0.