Revert FHL changes to useAsPressable #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
changed the title
rurikoaraki
approved these changes
Oct 27, 2021
…nto revert-fhl-hover-changes
ksiler
approved these changes
Oct 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
In #1061 , #1063 , #1068 , and #1074 I made a bunch of small changes to try and get us to stop using our port
useAsPressableand instead use the upstream Pressable component. I keep on finding regressions from my changes so I'm just going to undo all my changes 😕On the bright side, facebook/react-native#32405 got merged, so we can start the work to align the desktop platforms, and then follow through with FURN!
Verification
Pressable test page does what's expected. I'll do more passes through the win32 test app too once I can.
Pull request checklist
This PR has considered (when applicable):