-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow passing environment variables in AzureContainerAppsV0 task #17595
Allow passing environment variables in AzureContainerAppsV0 task #17595
Conversation
@microsoft-github-policy-service agree |
53e8d41
to
dc336f1
Compare
@Basssiiie Thanks for making this change! This looks good to me, and I'll make sure to port it over to our RC task and GitHub Action so folks are able to have compatible functionality there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 😃 |
@Basssiiie it appears the pipelines are failing due to the If you're able to, would you mind regenerating the
This should update a few dependencies in our lock file and hopefully the pipelines will pass so we can get this PR merged. Let me know if you have any issues with this and need me to take care of it. Thanks! |
@cormacpayne |
@Basssiiie Hmm for some reason, the pipelines aren't picking up the changes, no matter how many times I rebase against I have a PR that I'm going to open in our RC task repository that will include this change (along with a few other things), so when I bring those changes back into this stable task repository, I'll include these changes (if the PR hasn't been merged) and make sure that you get the development credit there if that's OK with you. |
@cormacpayne ah too bad it's not working out. But yes it's okay with me to merge it via the RC task. :) A side note is that I originally made the PR here per recommendation by the readme.md on the RC task's repo.
Maybe it's an idea to update that if this flow is having issues? |
@Basssiiie That's a good callout -- I'm hoping this is just a one-off issue for users looking to make changes to the task in this repository, but if it occurs again with another user, I'll update the documentation accordingly and port any changes made by customers in the RC task over to this task when it's released out-of-the-box with Azure Pipelines. |
I'm going to close this pull request since these changes were integrated into the |
Task name: AzureContainerAppsV0
Description: add the possibility to pass environment variables to the deployed container app, as supported by the CLI.
Documentation changes required: Y, any documentation outside this repository listing the available arguments for this task should be updated.
Added unit tests: N, there were no tests for similar arguments either so was not sure how to unit test it. If it is still preferred, please let me know with some pointers on how the test is preferred.
Attached related issue: Y, #17493, Azure/container-apps-deploy-pipelines-task#4
Checklist: