Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous updates based on feedback #10

Merged
merged 11 commits into from
Jan 30, 2023
Merged

Conversation

cormacpayne
Copy link
Member

This PR resolves the following items:

daniv-msft
daniv-msft previously approved these changes Jan 25, 2023
pauld-msft
pauld-msft previously approved these changes Jan 27, 2023
Copy link
Member

@pauld-msft pauld-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one take it or leave it nit but other than that LGTM :shipit:

azurecontainerapps/src/ContainerAppHelper.ts Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
overview.md Outdated Show resolved Hide resolved
@cormacpayne cormacpayne merged commit 9991808 into main Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants