add windows support for container tasks #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Attempts to resolve #6 |
|
@icornett Hey Ian, thanks again for making this change -- I just opened a PR with a bunch of miscellaneous changes from a variety of feedback sources, and bundled this change into it (since I had to tweak a few things): #10 The commit specific to your changes (and the corresponding issue you filed) can be found in this commit: c4e6839 I was going to close this PR in favor of the one I linked above, but wanted to make sure it was OK with you and that you felt your contributions to the task weren't getting lost. Just let me know! |
|
Sounds good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new method to attempt to detect Windows agents and download an appropriate version of pack which is unpacked using PowerShell 7