[AzureCloudPowerShellDeploymentV1] Implement ARM storage account support

[chelnak]

This initial PR attempts to add ARM storage account support to the cloud service deployment task.

The changes made will conditionally handle authentication and the retrieval of keys.

It would be good to get some initial feedback on the task. I'm sure what we are trying to achieve is possible and adding a feature like this would massively help organisations like mine migrate away from classic storage accounts.

It would also be good for some pointers on how to package this task with tfx as there is no manifest available to point at.

Reference issues #3683 & #10686

Many thanks!

[chelnak]

If this concept gets accepted, I am wondering whether it's best suited as a V2 of the task?

[Ajay-MS]

@chelnak Thanks for the contribution. There are few minor feedback and few indentation gaps. Can you address them.

Meanwhile, I will tryout the task on my setup and validate with few scenario's. Then i will merge the task.

[chelnak]

@Ajay-MS
Formatting tidied up and a check added after the keys are retrieved. I've also noticed a small issue with the additional function that i added, so that has been fixed as well.

[Ajay-MS]

@chelnak

I have few more comments. Please fix them and then I can merge the PR.

[chelnak]

@Ajay-MS Doing this right now!

[chelnak]

@Ajay-MS Comments addressed 👍

[Ajay-MS]

@chelnak
Minor version increment is still missing in task.loc.json can you please build task as I suggested.

Steps :
Build the task using command : node make.js build --task AzureCloudPowerShellDeploymentV1 . It will update the minor version in task.loc.json file too

[chelnak]

@Ajay-MS Task rebuilt and loc file submitted.

[Ajay-MS]

@chelnak Thanks for the changes. I have approved the branch.

I will merge it by today

[chelnak]

@Ajay-MS Great thank you. 🎉

What is your usual deployment schedule once an update hits master branch?

[Ajay-MS]

We have sprint for 3 weeks. Currently this is the first week of the sprint.

Once a sprint ends. We start it's deployment and generally it took around 2 week to get deployed across all the Rings.

[chelnak]

Great thank you!