Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure Cloud Service - use pubconfig storage account name #11233

Merged
merged 2 commits into from
Sep 4, 2019
Merged

Azure Cloud Service - use pubconfig storage account name #11233

merged 2 commits into from
Sep 4, 2019

Conversation

vincent1173
Copy link
Contributor

No description provided.

@vincent1173 vincent1173 requested a review from kmkumaran as a code owner August 28, 2019 06:09
@vincent1173
Copy link
Contributor Author

@chelnak, Please review this PR.
There is an issue found in your PR(#10740). Shouldn't we use the storage account name from config file for Diagnostics extensions instead of cloud service storage extension?

@chelnak
Copy link
Contributor

chelnak commented Aug 28, 2019 via email

@chelnak
Copy link
Contributor

chelnak commented Aug 28, 2019

@vincentdass - Just compared changes pre and post my PR. Good spot.

✔️

@vincent1173 vincent1173 merged commit 0624daf into master Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RoshanKumarMicrosoft RoshanKumarMicrosoft RoshanKumarMicrosoft approved these changes

@chshrikh chshrikh Awaiting requested review from chshrikh

@asranja asranja Awaiting requested review from asranja

@kmkumaran kmkumaran Awaiting requested review from kmkumaran

Assignees
No one assigned
Labels
Area: Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vincent1173 @chelnak @RoshanKumarMicrosoft