Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task "Azure Cloud Service Deployment" does not support the storage account created via ARM template #3683

Closed
tousinn opened this issue Feb 23, 2017 · 4 comments

Comments

@tousinn
Copy link

tousinn commented Feb 23, 2017

Hi there,

It looks like task "Azure Cloud Service Deployment" does not support the storage account created via ARM template.

When we pass a storage account created via ARM template to parameter "Storage Account", the task will end with error

"ResourceNotFound: The storage account 'XXXXXXXX' was not found."

It seems that in the function "Get-DiagnosticsExtensions", it will get the primary key of the storage like this

$primaryStorageKey = (Get-AzureStorageKey -StorageAccountName "$storageAccount").Primary

However, this will not be able to get the access key created by ARM template.

Is that possible to update the taks to support both the classic storage account and the one created by ARM template?

Thanks!

@jpricket
Copy link
Member

Hi @tousinn,

It appears that you already have a good understanding of the problem. Do you have a proposed solution? If so, you can fork this repository and submit a pull request with your solution. See the contributing document (https://github.com/Microsoft/vsts-tasks/blob/master/docs/contribute.md) for more details.
If you don't have a solution, we will try to prioritize the work, and get a solution as soon as possible.

Thanks,
Jason

@tousinn
Copy link
Author

tousinn commented Feb 27, 2017

Hi @jpricketMSFT

Thanks for you reply.

I have tried to submit my solution in the pull request
#3690

Please let me know if you have any questions.

Cheers,
Jin

@bryanmacfarlane bryanmacfarlane modified the milestone: TFS.vNext (onPrem) Mar 29, 2017
@kmkumaran kmkumaran removed this from the TFS.vNext (onPrem) milestone Apr 5, 2017
@Ajay-MS
Copy link

Ajay-MS commented Apr 5, 2017

@jpricketMSFT @tousinn

Azure cloud service deployment task is supposed to work with classic endpoints. Since it works with classic endpoint it can’t support ARM storage account in this task as ARM cmdlet can be access using ARM endpoint.

Cloud service is a classic resource. Modern storage accounts are ARM based resources. Both uses different types of endpoint to work with. That’s why I was not able to merge above PR.

@Ajay-MS Ajay-MS closed this as completed Apr 5, 2017
@RobLSDev
Copy link

@Ajay-MS - Is this really still an issue? From the Azure portal it allows users to deploy using an ARM-based storage account. It would be great if this functionality was supported in the pipelines so we could migrate all of our existing classic storage accounts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants