[Video conference] Settings UX tweaks #6406
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* VideoConference commits squash * VideoConference commits squash * VideoConferenceModule * Solution fix * function naming fix * import latest driver changes * give VideoConference projects a more suitable names * Do not list virtual camera in the settings * Fix installer after renaming * Community -> Enterprise * Fix VCCMS compilation * Basic settings<=>driver communication - select default webcam works (but breaks the driver if you need switch it while it's active) // TODO - overlay image works offline/online * fix settings crash * Fixed video mute for overlay * Restored VideoConference solution after merge * Create build.md * Added offset to border * Fix for shortucut guide crush * disable debug hook * Removed unused mutext * Fixed project build dependencies * Added black screen option as defualt VCam image * Installer fix * Enabled videoconference function start logging * Logging of most functions fails * Fix for compile waringn * Fixed bug with hangouts call overlay appear * Changed default overlay position * Fixed select image button margins and text alingment * Extra logging (#5267) * Extra logging * Added loggin to imageloader * added fail load image loading * Additional log * Fix * Another quick fix * ... * One extra debug * Fix * Possible fix * Fix with additional debugs * Forced uncompressed stream to fix blank frame * Logging refactor * Added mutex to logger * Now supporting only native aspect ratios * Fixed classical integer division bug * Preference for 16:9 * Fix for max resultion bug * Removed unnecessary log * Small fix * Changed video conference icon Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com> Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com> * Fix for faulty merge * Merged devdoc file * Unmuting on exit or module disabling * Added support for clicked mute/unmute * Added option to have overlay always on top * change logging path + cosmetic * Now suppoting other stream formats * Changed images to new ones * Added overlay position options * Dynamic webcam changing and fix hangouts bug * Moved overlay images to icons directory * Changed filter name * Added support for themes * Module directory rename * Added support to showing camera in-use to overlay Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com> Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com> * Fix for naming * reverse of unwanted changes * Fix * fix * fxi * fix Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com> Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>
niels9001
changed the title
|
@yuyoyuppe @enricogior This was branched off of feature/videoconference and should only contain 1 commit (b940b9a). No idea why it now indicates 16 commits and 179 files changed :|. |
|
@niels9001 nice! regarding commits count: looks like you need to hard reset the branch to its current upstream state and cherry-pick |
|
Closing this for #6432 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR is related to the Video Conference settings page:
Before:
After:
PR Checklist