Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Video conference] Settings UX tweaks #6432

Conversation

niels9001
Copy link
Contributor

Summary of the Pull Request

This PR is related to the Video Conference settings page:

  • Added subheaders.
  • Fixed the correct margins between UI elements
  • Added the module image.
  • Same responsive behavior as all other settings pages.
  • Fixed the module link.

Before:
image

After:
VideoConfSettings

PR Checklist

@enricogior
Copy link
Contributor

Let's call this Toolbar since Overlay is already used for the image we overlay when muting.

image

Copy link
Contributor

@enricogior enricogior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change needed from "overlay" to "toolbar", the other changes looks good!

@niels9001
Copy link
Contributor Author

One change needed from "overlay" to "toolbar", the other changes looks good!

Fixed!

Copy link
Contributor

@enricogior enricogior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@enricogior
Copy link
Contributor

@niels9001
do you want me to merge it?

@niels9001
Copy link
Contributor Author

@enricogior Yup, good to go

@enricogior enricogior merged commit 528c076 into feature/VideoConference Sep 8, 2020
@enricogior enricogior deleted the user/niels9001/videoconference-settingsUXtweaks branch September 8, 2020 08:23
ivan100sic pushed a commit to ivan100sic/PowerToys that referenced this pull request Sep 28, 2020
* Updated settings

* Updated settings

* Added image to installer

* Revert "Updated settings"

This reverts commit dee8cf6.

* Updated settings page

* Added keys

* Updated strings

* Updated toolbar text

Co-authored-by: Niels Laute <niels9001@hotmail.com>
ivan100sic pushed a commit to ivan100sic/PowerToys that referenced this pull request Sep 28, 2020
* Updated settings

* Updated settings

* Added image to installer

* Revert "Updated settings"

This reverts commit dee8cf6.

* Updated settings page

* Added keys

* Updated strings

* Updated toolbar text

Co-authored-by: Niels Laute <niels9001@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants