Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra logging #5267

Merged
merged 13 commits into from
Jul 28, 2020
Merged

Extra logging #5267

merged 13 commits into from
Jul 28, 2020

Conversation

PrzemyslawTusinski
Copy link
Contributor

Summary of the Pull Request

What is this about?

PR Checklist

  • Applies to #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

What does this include?

Validation Steps Performed

How does someone test & validate?

@PrzemyslawTusinski PrzemyslawTusinski merged commit 1bb1346 into microsoft:feature/VideoConference Jul 28, 2020
@PrzemyslawTusinski PrzemyslawTusinski deleted the ExtraLogging branch July 28, 2020 08:52
PrzemyslawTusinski added a commit that referenced this pull request Aug 11, 2020
* VideoConference commits squash

* VideoConference commits squash

* VideoConferenceModule

* Solution fix

* function naming fix

* import latest driver changes

* give VideoConference projects a more suitable names

* Do not list virtual camera in the settings

* Fix installer after renaming

* Community -> Enterprise

* Fix VCCMS compilation

* Basic settings<=>driver communication

- select default webcam works (but breaks the driver if you need switch it while it's active) // TODO
- overlay image works offline/online

* fix settings crash

* Fixed video mute for overlay

* Restored VideoConference solution after merge

* Create build.md

* Added offset to border

* Fix for shortucut guide crush

* disable debug hook

* Removed unused mutext

* Fixed project build dependencies

* Added black screen option as defualt VCam image

* Installer fix

* Enabled videoconference function start logging

* Logging of most functions fails

* Fix for compile waringn

* Fixed bug with hangouts call overlay appear

* Changed default overlay position

* Fixed select image button margins and text alingment

* Extra logging (#5267)

* Extra logging

* Added loggin to imageloader

* added fail load image loading

* Additional log

* Fix

* Another quick fix

* ...

* One extra debug

* Fix

* Possible fix

* Fix with additional debugs

* Forced uncompressed stream to fix blank frame

* Logging refactor

* Added mutex to logger

* Now supporting only native aspect ratios

* Fixed classical integer division bug

* Preference for 16:9

* Fix for max resultion bug

* Removed unnecessary log

* Small fix

* Changed video conference icon

Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com>
Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>

* Fix for faulty merge

* Merged devdoc file

* Unmuting on exit or module disabling

* Added support for clicked mute/unmute

* Added option to have overlay always on top

* change logging path + cosmetic

* Now suppoting other stream formats

* Changed images to new ones

* Added overlay position options

* Dynamic webcam changing and fix hangouts bug

* Moved overlay images to icons directory

* Changed filter name

* Added support for themes

* Module directory rename

* Added support to showing camera in-use to overlay

Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com>
Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>

* Fix for naming

* reverse of unwanted changes

* Fix

* fix

* fxi

* fix

Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com>
Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>
PrzemyslawTusinski added a commit that referenced this pull request Aug 24, 2020
* 11 08 snapshot (#10)

* VideoConference commits squash

* VideoConference commits squash

* VideoConferenceModule

* Solution fix

* function naming fix

* import latest driver changes

* give VideoConference projects a more suitable names

* Do not list virtual camera in the settings

* Fix installer after renaming

* Community -> Enterprise

* Fix VCCMS compilation

* Basic settings<=>driver communication

- select default webcam works (but breaks the driver if you need switch it while it's active) // TODO
- overlay image works offline/online

* fix settings crash

* Fixed video mute for overlay

* Restored VideoConference solution after merge

* Create build.md

* Added offset to border

* Fix for shortucut guide crush

* disable debug hook

* Removed unused mutext

* Fixed project build dependencies

* Added black screen option as defualt VCam image

* Installer fix

* Enabled videoconference function start logging

* Logging of most functions fails

* Fix for compile waringn

* Fixed bug with hangouts call overlay appear

* Changed default overlay position

* Fixed select image button margins and text alingment

* Extra logging (#5267)

* Extra logging

* Added loggin to imageloader

* added fail load image loading

* Additional log

* Fix

* Another quick fix

* ...

* One extra debug

* Fix

* Possible fix

* Fix with additional debugs

* Forced uncompressed stream to fix blank frame

* Logging refactor

* Added mutex to logger

* Now supporting only native aspect ratios

* Fixed classical integer division bug

* Preference for 16:9

* Fix for max resultion bug

* Removed unnecessary log

* Small fix

* Changed video conference icon

Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com>
Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>

* Fix for faulty merge

* Merged devdoc file

* Unmuting on exit or module disabling

* Added support for clicked mute/unmute

* Added option to have overlay always on top

* change logging path + cosmetic

* Now suppoting other stream formats

* Changed images to new ones

* Added overlay position options

* Dynamic webcam changing and fix hangouts bug

* Moved overlay images to icons directory

* Changed filter name

* Added support for themes

* Module directory rename

* Added support to showing camera in-use to overlay

Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com>
Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>

* Fix for naming

* reverse of unwanted changes

* Fix

* fix

* fxi

* fix

Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com>
Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>

* Disabling videoconference modules build

* Updated instlaling WDK build step

* further build step improvment

* New line fix

* New line

* Style fix

* new line

* new line

* Partial fix for allowing building w/o driver

* Conditional complie of video conference

* Fix for project configuration

* Fixed compilation

* Fix for powerlauncher install error

* Finalization of conditional build

* Skip certification when CIBuild

Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com>
Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>
PrzemyslawTusinski added a commit that referenced this pull request Aug 24, 2020
* 24 08 Squash (#6131)

* 11 08 snapshot (#10)

* VideoConference commits squash

* VideoConference commits squash

* VideoConferenceModule

* Solution fix

* function naming fix

* import latest driver changes

* give VideoConference projects a more suitable names

* Do not list virtual camera in the settings

* Fix installer after renaming

* Community -> Enterprise

* Fix VCCMS compilation

* Basic settings<=>driver communication

- select default webcam works (but breaks the driver if you need switch it while it's active) // TODO
- overlay image works offline/online

* fix settings crash

* Fixed video mute for overlay

* Restored VideoConference solution after merge

* Create build.md

* Added offset to border

* Fix for shortucut guide crush

* disable debug hook

* Removed unused mutext

* Fixed project build dependencies

* Added black screen option as defualt VCam image

* Installer fix

* Enabled videoconference function start logging

* Logging of most functions fails

* Fix for compile waringn

* Fixed bug with hangouts call overlay appear

* Changed default overlay position

* Fixed select image button margins and text alingment

* Extra logging (#5267)

* Extra logging

* Added loggin to imageloader

* added fail load image loading

* Additional log

* Fix

* Another quick fix

* ...

* One extra debug

* Fix

* Possible fix

* Fix with additional debugs

* Forced uncompressed stream to fix blank frame

* Logging refactor

* Added mutex to logger

* Now supporting only native aspect ratios

* Fixed classical integer division bug

* Preference for 16:9

* Fix for max resultion bug

* Removed unnecessary log

* Small fix

* Changed video conference icon

Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com>
Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>

* Fix for faulty merge

* Merged devdoc file

* Unmuting on exit or module disabling

* Added support for clicked mute/unmute

* Added option to have overlay always on top

* change logging path + cosmetic

* Now suppoting other stream formats

* Changed images to new ones

* Added overlay position options

* Dynamic webcam changing and fix hangouts bug

* Moved overlay images to icons directory

* Changed filter name

* Added support for themes

* Module directory rename

* Added support to showing camera in-use to overlay

Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com>
Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>

* Fix for naming

* reverse of unwanted changes

* Fix

* fix

* fxi

* fix

Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com>
Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>

* Disabling videoconference modules build

* Updated instlaling WDK build step

* further build step improvment

* New line fix

* New line

* Style fix

* new line

* new line

* Partial fix for allowing building w/o driver

* Conditional complie of video conference

* Fix for project configuration

* Fixed compilation

* Fix for powerlauncher install error

* Finalization of conditional build

* Skip certification when CIBuild

Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com>
Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>

* Removed extra configuration

* VideoC tab in settings now shows only if module if found, removed extra configs from VideoConference projects

Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com>
Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>
PrzemyslawTusinski added a commit that referenced this pull request Aug 26, 2020
* 24 08 Squash (#6131)

* 11 08 snapshot (#10)

* VideoConference commits squash

* VideoConference commits squash

* VideoConferenceModule

* Solution fix

* function naming fix

* import latest driver changes

* give VideoConference projects a more suitable names

* Do not list virtual camera in the settings

* Fix installer after renaming

* Community -> Enterprise

* Fix VCCMS compilation

* Basic settings<=>driver communication

- select default webcam works (but breaks the driver if you need switch it while it's active) // TODO
- overlay image works offline/online

* fix settings crash

* Fixed video mute for overlay

* Restored VideoConference solution after merge

* Create build.md

* Added offset to border

* Fix for shortucut guide crush

* disable debug hook

* Removed unused mutext

* Fixed project build dependencies

* Added black screen option as defualt VCam image

* Installer fix

* Enabled videoconference function start logging

* Logging of most functions fails

* Fix for compile waringn

* Fixed bug with hangouts call overlay appear

* Changed default overlay position

* Fixed select image button margins and text alingment

* Extra logging (#5267)

* Extra logging

* Added loggin to imageloader

* added fail load image loading

* Additional log

* Fix

* Another quick fix

* ...

* One extra debug

* Fix

* Possible fix

* Fix with additional debugs

* Forced uncompressed stream to fix blank frame

* Logging refactor

* Added mutex to logger

* Now supporting only native aspect ratios

* Fixed classical integer division bug

* Preference for 16:9

* Fix for max resultion bug

* Removed unnecessary log

* Small fix

* Changed video conference icon

Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com>
Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>

* Fix for faulty merge

* Merged devdoc file

* Unmuting on exit or module disabling

* Added support for clicked mute/unmute

* Added option to have overlay always on top

* change logging path + cosmetic

* Now suppoting other stream formats

* Changed images to new ones

* Added overlay position options

* Dynamic webcam changing and fix hangouts bug

* Moved overlay images to icons directory

* Changed filter name

* Added support for themes

* Module directory rename

* Added support to showing camera in-use to overlay

Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com>
Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>

* Fix for naming

* reverse of unwanted changes

* Fix

* fix

* fxi

* fix

Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com>
Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>

* Disabling videoconference modules build

* Updated instlaling WDK build step

* further build step improvment

* New line fix

* New line

* Style fix

* new line

* new line

* Partial fix for allowing building w/o driver

* Conditional complie of video conference

* Fix for project configuration

* Fixed compilation

* Fix for powerlauncher install error

* Finalization of conditional build

* Skip certification when CIBuild

Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com>
Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>

* Removed extra configuration

* VideoC tab in settings now shows only if module if found, removed extra configs from VideoConference projects

Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com>
Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>
PrzemyslawTusinski added a commit that referenced this pull request Aug 27, 2020
* 24 08 Squash (#6131)

* 11 08 snapshot (#10)

* VideoConference commits squash

* VideoConference commits squash

* VideoConferenceModule

* Solution fix

* function naming fix

* import latest driver changes

* give VideoConference projects a more suitable names

* Do not list virtual camera in the settings

* Fix installer after renaming

* Community -> Enterprise

* Fix VCCMS compilation

* Basic settings<=>driver communication

- select default webcam works (but breaks the driver if you need switch it while it's active) // TODO
- overlay image works offline/online

* fix settings crash

* Fixed video mute for overlay

* Restored VideoConference solution after merge

* Create build.md

* Added offset to border

* Fix for shortucut guide crush

* disable debug hook

* Removed unused mutext

* Fixed project build dependencies

* Added black screen option as defualt VCam image

* Installer fix

* Enabled videoconference function start logging

* Logging of most functions fails

* Fix for compile waringn

* Fixed bug with hangouts call overlay appear

* Changed default overlay position

* Fixed select image button margins and text alingment

* Extra logging (#5267)

* Extra logging

* Added loggin to imageloader

* added fail load image loading

* Additional log

* Fix

* Another quick fix

* ...

* One extra debug

* Fix

* Possible fix

* Fix with additional debugs

* Forced uncompressed stream to fix blank frame

* Logging refactor

* Added mutex to logger

* Now supporting only native aspect ratios

* Fixed classical integer division bug

* Preference for 16:9

* Fix for max resultion bug

* Removed unnecessary log

* Small fix

* Changed video conference icon

Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com>
Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>

* Fix for faulty merge

* Merged devdoc file

* Unmuting on exit or module disabling

* Added support for clicked mute/unmute

* Added option to have overlay always on top

* change logging path + cosmetic

* Now suppoting other stream formats

* Changed images to new ones

* Added overlay position options

* Dynamic webcam changing and fix hangouts bug

* Moved overlay images to icons directory

* Changed filter name

* Added support for themes

* Module directory rename

* Added support to showing camera in-use to overlay

Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com>
Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>

* Fix for naming

* reverse of unwanted changes

* Fix

* fix

* fxi

* fix

Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com>
Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>

* Disabling videoconference modules build

* Updated instlaling WDK build step

* further build step improvment

* New line fix

* New line

* Style fix

* new line

* new line

* Partial fix for allowing building w/o driver

* Conditional complie of video conference

* Fix for project configuration

* Fixed compilation

* Fix for powerlauncher install error

* Finalization of conditional build

* Skip certification when CIBuild

Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com>
Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>

* Removed extra configuration

* VideoC tab in settings now shows only if module if found, removed extra configs from VideoConference projects

Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com>
Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>
PrzemyslawTusinski added a commit that referenced this pull request Aug 28, 2020
* 24 08 Squash (#6131)

* 11 08 snapshot (#10)

* VideoConference commits squash

* VideoConference commits squash

* VideoConferenceModule

* Solution fix

* function naming fix

* import latest driver changes

* give VideoConference projects a more suitable names

* Do not list virtual camera in the settings

* Fix installer after renaming

* Community -> Enterprise

* Fix VCCMS compilation

* Basic settings<=>driver communication

- select default webcam works (but breaks the driver if you need switch it while it's active) // TODO
- overlay image works offline/online

* fix settings crash

* Fixed video mute for overlay

* Restored VideoConference solution after merge

* Create build.md

* Added offset to border

* Fix for shortucut guide crush

* disable debug hook

* Removed unused mutext

* Fixed project build dependencies

* Added black screen option as defualt VCam image

* Installer fix

* Enabled videoconference function start logging

* Logging of most functions fails

* Fix for compile waringn

* Fixed bug with hangouts call overlay appear

* Changed default overlay position

* Fixed select image button margins and text alingment

* Extra logging (#5267)

* Extra logging

* Added loggin to imageloader

* added fail load image loading

* Additional log

* Fix

* Another quick fix

* ...

* One extra debug

* Fix

* Possible fix

* Fix with additional debugs

* Forced uncompressed stream to fix blank frame

* Logging refactor

* Added mutex to logger

* Now supporting only native aspect ratios

* Fixed classical integer division bug

* Preference for 16:9

* Fix for max resultion bug

* Removed unnecessary log

* Small fix

* Changed video conference icon

Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com>
Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>

* Fix for faulty merge

* Merged devdoc file

* Unmuting on exit or module disabling

* Added support for clicked mute/unmute

* Added option to have overlay always on top

* change logging path + cosmetic

* Now suppoting other stream formats

* Changed images to new ones

* Added overlay position options

* Dynamic webcam changing and fix hangouts bug

* Moved overlay images to icons directory

* Changed filter name

* Added support for themes

* Module directory rename

* Added support to showing camera in-use to overlay

Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com>
Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>

* Fix for naming

* reverse of unwanted changes

* Fix

* fix

* fxi

* fix

Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com>
Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>

* Disabling videoconference modules build

* Updated instlaling WDK build step

* further build step improvment

* New line fix

* New line

* Style fix

* new line

* new line

* Partial fix for allowing building w/o driver

* Conditional complie of video conference

* Fix for project configuration

* Fixed compilation

* Fix for powerlauncher install error

* Finalization of conditional build

* Skip certification when CIBuild

Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com>
Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>

* Removed extra configuration

* VideoC tab in settings now shows only if module if found, removed extra configs from VideoConference projects

Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com>
Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>
yuyoyuppe added a commit that referenced this pull request Sep 1, 2020
* 24 08 Squash (#6131)

* 11 08 snapshot (#10)

* VideoConference commits squash

* VideoConference commits squash

* VideoConferenceModule

* Solution fix

* function naming fix

* import latest driver changes

* give VideoConference projects a more suitable names

* Do not list virtual camera in the settings

* Fix installer after renaming

* Community -> Enterprise

* Fix VCCMS compilation

* Basic settings<=>driver communication

- select default webcam works (but breaks the driver if you need switch it while it's active) // TODO
- overlay image works offline/online

* fix settings crash

* Fixed video mute for overlay

* Restored VideoConference solution after merge

* Create build.md

* Added offset to border

* Fix for shortucut guide crush

* disable debug hook

* Removed unused mutext

* Fixed project build dependencies

* Added black screen option as defualt VCam image

* Installer fix

* Enabled videoconference function start logging

* Logging of most functions fails

* Fix for compile waringn

* Fixed bug with hangouts call overlay appear

* Changed default overlay position

* Fixed select image button margins and text alingment

* Extra logging (#5267)

* Extra logging

* Added loggin to imageloader

* added fail load image loading

* Additional log

* Fix

* Another quick fix

* ...

* One extra debug

* Fix

* Possible fix

* Fix with additional debugs

* Forced uncompressed stream to fix blank frame

* Logging refactor

* Added mutex to logger

* Now supporting only native aspect ratios

* Fixed classical integer division bug

* Preference for 16:9

* Fix for max resultion bug

* Removed unnecessary log

* Small fix

* Changed video conference icon

Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com>
Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>

* Fix for faulty merge

* Merged devdoc file

* Unmuting on exit or module disabling

* Added support for clicked mute/unmute

* Added option to have overlay always on top

* change logging path + cosmetic

* Now suppoting other stream formats

* Changed images to new ones

* Added overlay position options

* Dynamic webcam changing and fix hangouts bug

* Moved overlay images to icons directory

* Changed filter name

* Added support for themes

* Module directory rename

* Added support to showing camera in-use to overlay

Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com>
Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>

* Fix for naming

* reverse of unwanted changes

* Fix

* fix

* fxi

* fix

Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com>
Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>

* Disabling videoconference modules build

* Updated instlaling WDK build step

* further build step improvment

* New line fix

* New line

* Style fix

* new line

* new line

* Partial fix for allowing building w/o driver

* Conditional complie of video conference

* Fix for project configuration

* Fixed compilation

* Fix for powerlauncher install error

* Finalization of conditional build

* Skip certification when CIBuild

Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com>
Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>

* Removed extra configuration

* VideoC tab in settings now shows only if module if found, removed extra configs from VideoConference projects

Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com>
Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant