-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
squash #6134
Merged
PrzemyslawTusinski
merged 3 commits into
microsoft:feature/VideoConference
from
PrzemyslawTusinski:backup
Aug 24, 2020
Merged
squash #6134
PrzemyslawTusinski
merged 3 commits into
microsoft:feature/VideoConference
from
PrzemyslawTusinski:backup
Aug 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 11 08 snapshot (#10) * VideoConference commits squash * VideoConference commits squash * VideoConferenceModule * Solution fix * function naming fix * import latest driver changes * give VideoConference projects a more suitable names * Do not list virtual camera in the settings * Fix installer after renaming * Community -> Enterprise * Fix VCCMS compilation * Basic settings<=>driver communication - select default webcam works (but breaks the driver if you need switch it while it's active) // TODO - overlay image works offline/online * fix settings crash * Fixed video mute for overlay * Restored VideoConference solution after merge * Create build.md * Added offset to border * Fix for shortucut guide crush * disable debug hook * Removed unused mutext * Fixed project build dependencies * Added black screen option as defualt VCam image * Installer fix * Enabled videoconference function start logging * Logging of most functions fails * Fix for compile waringn * Fixed bug with hangouts call overlay appear * Changed default overlay position * Fixed select image button margins and text alingment * Extra logging (#5267) * Extra logging * Added loggin to imageloader * added fail load image loading * Additional log * Fix * Another quick fix * ... * One extra debug * Fix * Possible fix * Fix with additional debugs * Forced uncompressed stream to fix blank frame * Logging refactor * Added mutex to logger * Now supporting only native aspect ratios * Fixed classical integer division bug * Preference for 16:9 * Fix for max resultion bug * Removed unnecessary log * Small fix * Changed video conference icon Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com> Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com> * Fix for faulty merge * Merged devdoc file * Unmuting on exit or module disabling * Added support for clicked mute/unmute * Added option to have overlay always on top * change logging path + cosmetic * Now suppoting other stream formats * Changed images to new ones * Added overlay position options * Dynamic webcam changing and fix hangouts bug * Moved overlay images to icons directory * Changed filter name * Added support for themes * Module directory rename * Added support to showing camera in-use to overlay Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com> Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com> * Fix for naming * reverse of unwanted changes * Fix * fix * fxi * fix Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com> Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com> * Disabling videoconference modules build * Updated instlaling WDK build step * further build step improvment * New line fix * New line * Style fix * new line * new line * Partial fix for allowing building w/o driver * Conditional complie of video conference * Fix for project configuration * Fixed compilation * Fix for powerlauncher install error * Finalization of conditional build * Skip certification when CIBuild Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com> Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>
…ra configs from VideoConference projects
PrzemyslawTusinski
added a commit
that referenced
this pull request
Aug 26, 2020
* 24 08 Squash (#6131) * 11 08 snapshot (#10) * VideoConference commits squash * VideoConference commits squash * VideoConferenceModule * Solution fix * function naming fix * import latest driver changes * give VideoConference projects a more suitable names * Do not list virtual camera in the settings * Fix installer after renaming * Community -> Enterprise * Fix VCCMS compilation * Basic settings<=>driver communication - select default webcam works (but breaks the driver if you need switch it while it's active) // TODO - overlay image works offline/online * fix settings crash * Fixed video mute for overlay * Restored VideoConference solution after merge * Create build.md * Added offset to border * Fix for shortucut guide crush * disable debug hook * Removed unused mutext * Fixed project build dependencies * Added black screen option as defualt VCam image * Installer fix * Enabled videoconference function start logging * Logging of most functions fails * Fix for compile waringn * Fixed bug with hangouts call overlay appear * Changed default overlay position * Fixed select image button margins and text alingment * Extra logging (#5267) * Extra logging * Added loggin to imageloader * added fail load image loading * Additional log * Fix * Another quick fix * ... * One extra debug * Fix * Possible fix * Fix with additional debugs * Forced uncompressed stream to fix blank frame * Logging refactor * Added mutex to logger * Now supporting only native aspect ratios * Fixed classical integer division bug * Preference for 16:9 * Fix for max resultion bug * Removed unnecessary log * Small fix * Changed video conference icon Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com> Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com> * Fix for faulty merge * Merged devdoc file * Unmuting on exit or module disabling * Added support for clicked mute/unmute * Added option to have overlay always on top * change logging path + cosmetic * Now suppoting other stream formats * Changed images to new ones * Added overlay position options * Dynamic webcam changing and fix hangouts bug * Moved overlay images to icons directory * Changed filter name * Added support for themes * Module directory rename * Added support to showing camera in-use to overlay Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com> Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com> * Fix for naming * reverse of unwanted changes * Fix * fix * fxi * fix Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com> Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com> * Disabling videoconference modules build * Updated instlaling WDK build step * further build step improvment * New line fix * New line * Style fix * new line * new line * Partial fix for allowing building w/o driver * Conditional complie of video conference * Fix for project configuration * Fixed compilation * Fix for powerlauncher install error * Finalization of conditional build * Skip certification when CIBuild Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com> Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com> * Removed extra configuration * VideoC tab in settings now shows only if module if found, removed extra configs from VideoConference projects Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com> Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>
PrzemyslawTusinski
added a commit
that referenced
this pull request
Aug 27, 2020
* 24 08 Squash (#6131) * 11 08 snapshot (#10) * VideoConference commits squash * VideoConference commits squash * VideoConferenceModule * Solution fix * function naming fix * import latest driver changes * give VideoConference projects a more suitable names * Do not list virtual camera in the settings * Fix installer after renaming * Community -> Enterprise * Fix VCCMS compilation * Basic settings<=>driver communication - select default webcam works (but breaks the driver if you need switch it while it's active) // TODO - overlay image works offline/online * fix settings crash * Fixed video mute for overlay * Restored VideoConference solution after merge * Create build.md * Added offset to border * Fix for shortucut guide crush * disable debug hook * Removed unused mutext * Fixed project build dependencies * Added black screen option as defualt VCam image * Installer fix * Enabled videoconference function start logging * Logging of most functions fails * Fix for compile waringn * Fixed bug with hangouts call overlay appear * Changed default overlay position * Fixed select image button margins and text alingment * Extra logging (#5267) * Extra logging * Added loggin to imageloader * added fail load image loading * Additional log * Fix * Another quick fix * ... * One extra debug * Fix * Possible fix * Fix with additional debugs * Forced uncompressed stream to fix blank frame * Logging refactor * Added mutex to logger * Now supporting only native aspect ratios * Fixed classical integer division bug * Preference for 16:9 * Fix for max resultion bug * Removed unnecessary log * Small fix * Changed video conference icon Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com> Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com> * Fix for faulty merge * Merged devdoc file * Unmuting on exit or module disabling * Added support for clicked mute/unmute * Added option to have overlay always on top * change logging path + cosmetic * Now suppoting other stream formats * Changed images to new ones * Added overlay position options * Dynamic webcam changing and fix hangouts bug * Moved overlay images to icons directory * Changed filter name * Added support for themes * Module directory rename * Added support to showing camera in-use to overlay Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com> Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com> * Fix for naming * reverse of unwanted changes * Fix * fix * fxi * fix Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com> Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com> * Disabling videoconference modules build * Updated instlaling WDK build step * further build step improvment * New line fix * New line * Style fix * new line * new line * Partial fix for allowing building w/o driver * Conditional complie of video conference * Fix for project configuration * Fixed compilation * Fix for powerlauncher install error * Finalization of conditional build * Skip certification when CIBuild Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com> Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com> * Removed extra configuration * VideoC tab in settings now shows only if module if found, removed extra configs from VideoConference projects Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com> Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>
PrzemyslawTusinski
added a commit
that referenced
this pull request
Aug 28, 2020
* 24 08 Squash (#6131) * 11 08 snapshot (#10) * VideoConference commits squash * VideoConference commits squash * VideoConferenceModule * Solution fix * function naming fix * import latest driver changes * give VideoConference projects a more suitable names * Do not list virtual camera in the settings * Fix installer after renaming * Community -> Enterprise * Fix VCCMS compilation * Basic settings<=>driver communication - select default webcam works (but breaks the driver if you need switch it while it's active) // TODO - overlay image works offline/online * fix settings crash * Fixed video mute for overlay * Restored VideoConference solution after merge * Create build.md * Added offset to border * Fix for shortucut guide crush * disable debug hook * Removed unused mutext * Fixed project build dependencies * Added black screen option as defualt VCam image * Installer fix * Enabled videoconference function start logging * Logging of most functions fails * Fix for compile waringn * Fixed bug with hangouts call overlay appear * Changed default overlay position * Fixed select image button margins and text alingment * Extra logging (#5267) * Extra logging * Added loggin to imageloader * added fail load image loading * Additional log * Fix * Another quick fix * ... * One extra debug * Fix * Possible fix * Fix with additional debugs * Forced uncompressed stream to fix blank frame * Logging refactor * Added mutex to logger * Now supporting only native aspect ratios * Fixed classical integer division bug * Preference for 16:9 * Fix for max resultion bug * Removed unnecessary log * Small fix * Changed video conference icon Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com> Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com> * Fix for faulty merge * Merged devdoc file * Unmuting on exit or module disabling * Added support for clicked mute/unmute * Added option to have overlay always on top * change logging path + cosmetic * Now suppoting other stream formats * Changed images to new ones * Added overlay position options * Dynamic webcam changing and fix hangouts bug * Moved overlay images to icons directory * Changed filter name * Added support for themes * Module directory rename * Added support to showing camera in-use to overlay Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com> Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com> * Fix for naming * reverse of unwanted changes * Fix * fix * fxi * fix Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com> Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com> * Disabling videoconference modules build * Updated instlaling WDK build step * further build step improvment * New line fix * New line * Style fix * new line * new line * Partial fix for allowing building w/o driver * Conditional complie of video conference * Fix for project configuration * Fixed compilation * Fix for powerlauncher install error * Finalization of conditional build * Skip certification when CIBuild Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com> Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com> * Removed extra configuration * VideoC tab in settings now shows only if module if found, removed extra configs from VideoConference projects Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com> Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>
yuyoyuppe
added a commit
that referenced
this pull request
Sep 1, 2020
* 24 08 Squash (#6131) * 11 08 snapshot (#10) * VideoConference commits squash * VideoConference commits squash * VideoConferenceModule * Solution fix * function naming fix * import latest driver changes * give VideoConference projects a more suitable names * Do not list virtual camera in the settings * Fix installer after renaming * Community -> Enterprise * Fix VCCMS compilation * Basic settings<=>driver communication - select default webcam works (but breaks the driver if you need switch it while it's active) // TODO - overlay image works offline/online * fix settings crash * Fixed video mute for overlay * Restored VideoConference solution after merge * Create build.md * Added offset to border * Fix for shortucut guide crush * disable debug hook * Removed unused mutext * Fixed project build dependencies * Added black screen option as defualt VCam image * Installer fix * Enabled videoconference function start logging * Logging of most functions fails * Fix for compile waringn * Fixed bug with hangouts call overlay appear * Changed default overlay position * Fixed select image button margins and text alingment * Extra logging (#5267) * Extra logging * Added loggin to imageloader * added fail load image loading * Additional log * Fix * Another quick fix * ... * One extra debug * Fix * Possible fix * Fix with additional debugs * Forced uncompressed stream to fix blank frame * Logging refactor * Added mutex to logger * Now supporting only native aspect ratios * Fixed classical integer division bug * Preference for 16:9 * Fix for max resultion bug * Removed unnecessary log * Small fix * Changed video conference icon Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com> Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com> * Fix for faulty merge * Merged devdoc file * Unmuting on exit or module disabling * Added support for clicked mute/unmute * Added option to have overlay always on top * change logging path + cosmetic * Now suppoting other stream formats * Changed images to new ones * Added overlay position options * Dynamic webcam changing and fix hangouts bug * Moved overlay images to icons directory * Changed filter name * Added support for themes * Module directory rename * Added support to showing camera in-use to overlay Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com> Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com> * Fix for naming * reverse of unwanted changes * Fix * fix * fxi * fix Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com> Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com> * Disabling videoconference modules build * Updated instlaling WDK build step * further build step improvment * New line fix * New line * Style fix * new line * new line * Partial fix for allowing building w/o driver * Conditional complie of video conference * Fix for project configuration * Fixed compilation * Fix for powerlauncher install error * Finalization of conditional build * Skip certification when CIBuild Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com> Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com> * Removed extra configuration * VideoC tab in settings now shows only if module if found, removed extra configs from VideoConference projects Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com> Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about?
PR Checklist
Info on Pull Request
What does this include?
Validation Steps Performed
How does someone test & validate?