Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspaces] Sequential launch #35297

Merged
merged 14 commits into from
Oct 14, 2024

Conversation

SeraphimaZykova
Copy link
Collaborator

Summary of the Pull Request

Launching the next instance of the app only after the previous one has appeared. This ensures that we avoid errors when launching other instances (e.g. "The app is already running") and placing app instances in the correct positions.

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

  • Launch a workspace with several instances of the app, e.g., Outlook. Verify all instances are launched without error, and placed correctly.
  • Verify canceling the launch works as expected.

@crutkas
Copy link
Member

crutkas commented Oct 9, 2024

Does #35059 and this conflict?

@donlaci
Copy link
Collaborator

donlaci commented Oct 9, 2024

@crutkas #35059 will be deleted, this one will be kept.

Copy link
Collaborator

@donlaci donlaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@crutkas
Copy link
Member

crutkas commented Oct 10, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@SeraphimaZykova SeraphimaZykova merged commit 9994fd7 into main Oct 14, 2024
16 checks passed
@SeraphimaZykova SeraphimaZykova deleted the dev/seraphima/workspaces-sequential-launch branch October 14, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants