Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspaces] launch same apps sequentially #35059

Closed
wants to merge 1 commit into from

Conversation

donlaci
Copy link
Collaborator

@donlaci donlaci commented Sep 25, 2024

Summary of the Pull Request

If there are multiple instances of the same app, Workspaces will launch them sequentially, waiting for each new instance to appear befor launching a new instance. It is needed for example for MS Outlook

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Tested locally

@crutkas crutkas added Needs-Review This Pull Request awaits the review of a maintainer. In for .85 labels Sep 25, 2024
Copy link
Collaborator

@SeraphimaZykova SeraphimaZykova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this approach, it doesn't work as intended and it's unsafe.
You're accessing m_needAdditionalLaunch from different threads, potentially leading to a crash.

@SeraphimaZykova
Copy link
Collaborator

Closing in favor of #35297

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Review This Pull Request awaits the review of a maintainer.
Projects
Development

Successfully merging this pull request may close these issues.

4 participants