Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require validator ver 1.3 for link without version #5714

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

pow2clk
Copy link
Member

@pow2clk pow2clk commented Sep 14, 2023

Require a lesser validator version for linking without version for RunLinkWithTempReg test in order to allow the test to run on older validators. 1.3 is the lowest version that supports libraries

Another follow up to #5378

Require a lesser validator version for linking without version for
RunLinkWithTempReg test in order to allow the test to run on older
validators. 1.3 is the lowest version that supports libraries

Another follow up to microsoft#5378
@pow2clk pow2clk requested a review from hekota September 14, 2023 12:22
@pow2clk
Copy link
Member Author

pow2clk commented Sep 14, 2023

A more direct followup to #5629

Copy link
Contributor

@tex3d tex3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pow2clk pow2clk merged commit c3b8a14 into microsoft:main Sep 14, 2023
@pow2clk pow2clk deleted the tempreg-validator branch September 14, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants