Error on diff blob versions part 1 #5378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Build DirectXShaderCompiler 1.0.3461 failed (commit 199f0a2985 by @bob80905) |
bob80905
force-pushed
the
error_on_diff_blob_versions_part1
branch
2 times, most recently
from
d2e0f83 to
8d72f47
Compare
bob80905
force-pushed
the
error_on_diff_blob_versions_part1
branch
from
80ef3fb to
ccc9d46
Compare
tex3d
requested changes
Jun 30, 2023
tex3d
reviewed
Jul 6, 2023
tex3d
reviewed
Jul 6, 2023
python3kgae
approved these changes
Jul 10, 2023
pow2clk
added a commit
to pow2clk/DirectXShaderCompiler
that referenced
this pull request
Aug 31, 2023
The container builder determines whether to include the version in the compiled shader library depending on the validator version. If the version is below 1.8, it won't include it and any linking is allowed. If it is 1.8 or above, the version will prevent linking with a non-versioned compile. RunLinkWithTempReg assembled one library shader and compiled another. As such, one had a version and the other didn't. By forcing the link to use an earlier validator version, the link is again allowed Followup to microsoft#5378
pow2clk
added a commit
to pow2clk/DirectXShaderCompiler
that referenced
this pull request
Aug 31, 2023
The container builder determines whether to include the version in the compiled shader library depending on the validator version. If the version is below 1.8, it won't include it and any linking is allowed. If it is 1.8 or above, the version will prevent linking with a non-versioned compile. RunLinkWithTempReg assembled one library shader and compiled another. As such, one had a version and the other didn't. By forcing the link to use an earlier validator version, the link is again allowed Followup to microsoft#5378
pow2clk
added a commit
that referenced
this pull request
Aug 31, 2023
The container builder determines whether to include the version in the compiled shader library depending on the validator version. If the version is below 1.8, it won't include it and any linking is allowed. If it is 1.8 or above, the version will prevent linking with a non-versioned compile. RunLinkWithTempReg assembled one library shader and compiled another. As such, one had a version and the other didn't. By forcing the compile to use an earlier validator version, the link is again allowed Followup to #5378
pow2clk
added a commit
to pow2clk/DirectXShaderCompiler
that referenced
this pull request
Sep 14, 2023
Require a lesser validator version for linking without version for RunLinkWithTempReg test in order to allow the test to run on older validators. 1.3 is the lowest version that supports libraries Another follow up to microsoft#5378
pow2clk
added a commit
to pow2clk/DirectXShaderCompiler
that referenced
this pull request
Sep 14, 2023
Require a lesser validator version for linking without version for RunLinkWithTempReg test in order to allow the test to run on older validators. 1.3 is the lowest version that supports libraries Another follow up to microsoft#5378
pow2clk
added a commit
that referenced
this pull request
Sep 14, 2023
Require a lesser validator version for linking without version for RunLinkWithTempReg test in order to allow the test to run on older validators. 1.3 is the lowest version that supports libraries Another follow up to #5378
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first of 2 PRs to prevent libraries of different compiler versions from linking together. This first PR implements adding the compiler version information into the Dxil Container itself, to allow for comparison later. It also adds some basic validation to the new part in the Dxil Container.