Skip to content

Commit

Permalink
Require validator ver 1.3 for link without version (#5714)
Browse files Browse the repository at this point in the history
Require a lesser validator version for linking without version for
RunLinkWithTempReg test in order to allow the test to run on older
validators. 1.3 is the lowest version that supports libraries

Another follow up to #5378
  • Loading branch information
pow2clk authored Sep 14, 2023
1 parent 67fde16 commit c3b8a14
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/clang/unittests/HLSL/LinkerTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -946,7 +946,7 @@ TEST_F(LinkerTest, RunLinkWithTempReg) {
AssembleLib(L"..\\HLSLFileCheck\\dxil\\linker\\TempReg.ll", &pTempRegLib);
CComPtr<IDxcBlob> pEntryLib;
CompileLib(L"..\\HLSLFileCheck\\dxil\\linker\\use-TempReg.hlsl", &pEntryLib,
{L"-validator-version", L"1.7"}, L"lib_6_3");
{L"-validator-version", L"1.3"}, L"lib_6_3");
CComPtr<IDxcLinker> pLinker;
CreateLinker(&pLinker);
LPCWSTR libName = L"entry";
Expand Down

0 comments on commit c3b8a14

Please sign in to comment.