Debump Node.js requirement to 10.14.2 (#3854)

* Debump Node.js requirement to 10.14.2 * Update entry * Typo Co-authored-by: Corina <14900841+corinagum@users.noreply.github.com>
microsoft · Jun 22, 2021 · db45df3 · db45df3
1 parent 1a1b44b
commit db45df3
Show file tree

Hide file tree

Showing 6 changed files with 59 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -22,6 +22,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
+### Fixed
+
+-  Fixes [#3816](https://github.com/microsoft/BotFramework-WebChat/issues/3816). De-bumped Node.js engine requirement for Direct Line Speech SDK to `>= 10.14.2` from `>= 12.0.0`, by [@compulim](https://github.com/compulim) in PR [#3854](https://github.com/microsoft/BotFramework-WebChat/pull/3854)
+
 ### Changed
 
 -  Bumped all dependencies to the latest versions and sample bumps, by [@compulim](https://github.com/compulim) in PR [#3831](https://github.com/microsoft/BotFramework-WebChat/pull/3831) and PR [#3846](https://github.com/microsoft/BotFramework-WebChat/pull/3846)

diff --git a/__tests__/constants.json b/__tests__/constants.json
@@ -12,8 +12,8 @@
     "fetchImage": 5000,
     "navigation": 10000,
     "postActivity": 30000,
-    "scrollToBottom": 2000,
-    "test": 30000,
+    "scrollToBottom": 4000,
+    "test": 50000,
     "ui": 1000
   }
 }
diff --git a/__tests__/html/carousel.navigation.tab.cardInput.html b/__tests__/html/carousel.navigation.tab.cardInput.html
@@ -0,0 +1,50 @@
+<!DOCTYPE html>
+<html lang="en-US">
+  <head>
+    <script crossorigin="anonymous" src="/__dist__/testharness.js"></script>
+    <script crossorigin="anonymous" src="/__dist__/webchat-es5.js"></script>
+    <script crossorigin="anonymous" src="assets/transcript.navigation.js" type="text/babel"></script>
+  </head>
+  <body>
+    <div id="webchat"></div>
+    <script type="text/babel" data-presets="env,stage-3,react">
+      const {
+        TestAsset: { waitForFocusedActivityInView },
+        WebChatTest: { conditions, createDirectline, createStore, host, pageObjects, timeouts, token }
+      } = window;
+
+      (async function () {
+        window.WebChat.renderWebChat(
+          {
+            directLine: createDirectLine({ token: await token.fetchDirectLineToken() }),
+            store: createStore()
+          },
+          document.getElementById('webchat')
+        );
+
+        await pageObjects.wait(conditions.uiConnected(), timeouts.directLine);
+
+        await pageObjects.sendMessageViaSendBox('carousel', { waitForSend: true });
+
+        await pageObjects.wait(conditions.allImagesLoaded(), timeouts.fetch);
+
+        // Move focus to carousel activity
+        await host.sendShiftTab();
+        await host.sendShiftTab();
+        await host.sendShiftTab();
+        await waitForFocusedActivityInView();
+
+        await host.sendKeys('ENTER');
+        // focus on first card button
+        await host.sendTab();
+        await host.snapshot();
+
+        await host.done();
+      })().catch(async err => {
+        console.error(err);
+
+        await host.error(err);
+      });
+    </script>
+  </body>
+</html>
diff --git a/__tests__/html/hooks.useObserveScrollPosition.html b/__tests__/html/hooks.useObserveScrollPosition.html
@@ -67,7 +67,7 @@
         await pageObjects.wait(conditions.minNumActivitiesShown(2), timeouts.directLine);
 
         // Wait until the scroll view stabilized, we should have a few numbers in the "positions" array.
-        await pageObjects.wait(conditions.scrollStabilized(), timeouts.ui);
+        await pageObjects.wait(conditions.scrollStabilized(), timeouts.test);
 
         // There should be at least 5 measurements while the transcript auto scroll.
         expect(positions.length).toBeGreaterThanOrEqual(5);

diff --git a/__tests__/html/hooks.useScrollToEnd.hideNewMessagesButton.html b/__tests__/html/hooks.useScrollToEnd.hideNewMessagesButton.html
@@ -69,7 +69,7 @@
         await pageObjects.wait(conditions.minNumActivitiesShown(4), timeouts.directLine);
 
         // The "New messages" button should show up
-        await pageObjects.wait(conditions.newMessageButtonShown(), timeouts.ui);
+        await pageObjects.wait(conditions.newMessageButtonShown(), timeouts.test);
 
         // Call "scrollToEnd" should hide the "New messages" button immediately
         await renderWithFunction(() => useScrollToEnd()());

diff --git a/packages/directlinespeech/package.json b/packages/directlinespeech/package.json
@@ -67,6 +67,6 @@
     "web-speech-cognitive-services": "7.1.0"
   },
   "engines": {
-    "node": ">=12.0.0"
+    "node": ">= 10.14.2"
   }
 }