Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debump Node.js requirement to 10.14.2 #3854

Merged
merged 6 commits into from
Apr 22, 2021
Merged

Debump Node.js requirement to 10.14.2 #3854

merged 6 commits into from
Apr 22, 2021

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Apr 16, 2021 •
edited
Loading

Fixes #3816.

Changelog Entry

Fixed

  • Fixes #3816. De-bumped Node.js engine requirement for Direct Line Speech SDK to >= 10.14.2 from >= 12.0.0, by @compulim in PR #3854

Description

De-bump Node.js engine requirement for Direct Line Speech SDK. Based on data from its package-lock.json, the minimal version supported is 10.14.2.

Specific Changes

  • Update packages/directlinespeech/package.json to set engines.node to >= 10.14.2
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • ~Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • ~Browser and platform compatibilities reviewed
  • ~CSS styles reviewed (minimal rules, no z-index)
  • ~Documents reviewed (docs, samples, live demo)
  • ~Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • ~Security reviewed (no data URIs, check for nonce leak)
  • ~Tests reviewed (coverage, legitimacy)

@compulim compulim marked this pull request as ready for review April 16, 2021 07:41
corinagum
corinagum reviewed Apr 16, 2021
View reviewed changes
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you verify our documentation is up to date? I feel like we added recently this info in a doc.

@compulim
Copy link
Contributor Author

compulim commented Apr 16, 2021 •
edited
Loading

Can you verify our documentation is up to date? I feel like we added recently this info in a doc.

I searched with multiple keywords like 12, Node.js, engine, requirement, but couldn't find it. Can you point it out for me?

@corinagum
Copy link
Contributor

Ah okay. Just checked CONTRIBUTING.md and it looks like we have npm min version but not node. Do you think you could add it?

@compulim
Copy link
Contributor Author

CONTRIBUTING.md looks good to me, it said "Node.js of LTS or latest version". That means latest of 10, 12, 14 and 15.

@corinagum corinagum enabled auto-merge (squash) April 20, 2021 21:21
@corinagum
Copy link
Contributor

corinagum commented Apr 21, 2021 •
edited
Loading

Pulling this branch and testing locally for sanity check

[Edit] Okay it took a while, but I was able to get tests passing locally. ADO just hates me. I'll keep babysitting.

@corinagum corinagum merged commit 133193f into master Apr 22, 2021
@corinagum corinagum deleted the fix-3816 branch April 22, 2021 22:29
compulim added a commit that referenced this pull request Jun 22, 2021
@compulim @corinagum
Debump Node.js requirement to 10.14.2 (#3854)
db45df3 
* Debump Node.js requirement to 10.14.2

* Update entry

* Typo

Co-authored-by: Corina <14900841+corinagum@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@beyackle beyackle Awaiting requested review from beyackle

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@tdurnford tdurnford Awaiting requested review from tdurnford tdurnford is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

botframework-directlinespeech sdk not compatible with spfx 1.11
2 participants
@compulim @corinagum