Bump adaptivecards@2.9.0 (#3846)

* Bump adaptivecards@2.9.0 * Update entry * Update screenshots * Fix test * Fix test * Fix test * Fix tests * Fix tests
microsoft · Jun 22, 2021 · 1a1b44b · 1a1b44b
1 parent 04a1a81
commit 1a1b44b
Show file tree

Hide file tree

Showing 16 changed files with 17 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -24,7 +24,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ### Changed
 
--  Bumped all dependencies to the latest versions and sample bumps, by [@compulim](https://github.com/compulim) in PR [#3831](https://github.com/microsoft/BotFramework-WebChat/pull/3831)
+-  Bumped all dependencies to the latest versions and sample bumps, by [@compulim](https://github.com/compulim) in PR [#3831](https://github.com/microsoft/BotFramework-WebChat/pull/3831) and PR [#3846](https://github.com/microsoft/BotFramework-WebChat/pull/3846)
    -  Development dependencies
       -  [`@azure/storage-blob@12.5.0`](https://npmjs.com/package/@azure/storage-blob)
       -  [`@babel/cli@7.13.14`](https://npmjs.com/package/@babel/cli)
@@ -96,6 +96,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
       -  [`webpack@4.46.0`](https://npmjs.com/package/webpack)
    -  Production dependencies
       -  [`@emotion/css@11.1.3`](https://npmjs.com/package/@emotion/css), moved from [`create-emotion`](https://npmjs.com/package/create-emotion)
+      -  [`adaptivecards@2.9.0`](https://npmjs.com/package/adaptivecards)
       -  [`classnames@2.3.1`](https://npmjs.com/package/classnames)
       -  [`core-js@3.10.0`](https://npmjs.com/package/core-js)
       -  [`react-redux@7.2.3`](https://npmjs.com/package/react-redux)

diff --git a/...mage_snapshots__/chrome-docker/adaptive-cards-js-disable-card-inputs-3-snap.png b/...mage_snapshots__/chrome-docker/adaptive-cards-js-disable-card-inputs-3-snap.png
diff --git a/...ive-cards-js-inputs-card-with-custom-style-options-and-submit-action-1-snap.png b/...ive-cards-js-inputs-card-with-custom-style-options-and-submit-action-1-snap.png
diff --git a/...ottom-if-submitting-an-adaptive-card-while-suggested-actions-is-open-1-snap.png b/...ottom-if-submitting-an-adaptive-card-while-suggested-actions-is-open-1-snap.png
diff --git a/...oll-to-bottom-js-show-new-messages-button-only-when-new-message-come-1-snap.png b/...oll-to-bottom-js-show-new-messages-button-only-when-new-message-come-1-snap.png
diff --git a/...oll-to-bottom-js-show-new-messages-button-only-when-new-message-come-2-snap.png b/...oll-to-bottom-js-show-new-messages-button-only-when-new-message-come-2-snap.png
diff --git a/...oll-to-bottom-js-show-new-messages-button-only-when-new-message-come-3-snap.png b/...oll-to-bottom-js-show-new-messages-button-only-when-new-message-come-3-snap.png
diff --git a/...oll-to-bottom-js-show-new-messages-button-only-when-new-message-come-4-snap.png b/...oll-to-bottom-js-show-new-messages-button-only-when-new-message-come-4-snap.png
diff --git a/...card-agenda-js-adaptive-card-card-agenda-with-schema-1-3-should-pass-1-snap.png b/...card-agenda-js-adaptive-card-card-agenda-with-schema-1-3-should-pass-1-snap.png
diff --git a/...ion-adaptive-card-card-agenda-transcript-js-adaptive-card-schema-1-3-1-snap.png b/...ion-adaptive-card-card-agenda-transcript-js-adaptive-card-schema-1-3-1-snap.png
diff --git a/...shots__/html/hooks-use-text-box-js-use-text-box-should-work-properly-1-snap.png b/...shots__/html/hooks-use-text-box-js-use-text-box-should-work-properly-1-snap.png
diff --git a/...shots__/html/hooks-use-text-box-js-use-text-box-should-work-properly-2-snap.png b/...shots__/html/hooks-use-text-box-js-use-text-box-should-work-properly-2-snap.png
diff --git a/__tests__/adaptiveCards.js b/__tests__/adaptiveCards.js
@@ -111,6 +111,7 @@ test('disable card inputs', async () => {
     document.querySelector('.ac-adaptiveCard input[type="radio"]').checked = true;
     document.querySelector('.ac-adaptiveCard input[type="text"]').value = 'William';
     document.querySelector('.ac-adaptiveCard input[type="time"]').value = '12:34';
+    document.querySelector('.ac-adaptiveCard input[type="number"]').value = '1';
     document.querySelector('.ac-adaptiveCard select').value = '1';
     document.querySelector('.ac-adaptiveCard textarea').value = 'One Redmond Way, Redmond, WA';
   });
@@ -189,6 +190,11 @@ test('Inputs card with custom style options and submit action', async () => {
   await driver.wait(minNumActivitiesShown(2), timeouts.directLine);
   await driver.wait(allImagesLoaded(), timeouts.fetchImage);
 
+  // To submit the input form, the number field is mandatory.
+  await driver.executeScript(() => {
+    document.querySelector('.ac-adaptiveCard input[type="number"]').value = '1';
+  });
+
   // Click "Submit" button should change the button color
   await driver.executeScript(() => {
     document.querySelector('.ac-actionSet button:nth-of-type(2)').click();

diff --git a/__tests__/scrollToBottom.js b/__tests__/scrollToBottom.js
@@ -26,6 +26,11 @@ test('should stick to bottom if submitting an Adaptive Card while suggested acti
   await driver.wait(suggestedActionsShown(), timeouts.directLine);
   await driver.wait(scrollToBottomCompleted(), timeouts.scrollToBottom);
 
+  // To submit the input form, the number field is mandatory.
+  await driver.executeScript(() => {
+    document.querySelector('.ac-adaptiveCard input[type="number"]').value = '1';
+  });
+
   const submitButton = await driver.findElement(By.css('button.ac-pushButton:nth-of-type(2)'));
 
   await submitButton.click();

diff --git a/packages/bundle/package-lock.json b/packages/bundle/package-lock.json
diff --git a/packages/bundle/package.json b/packages/bundle/package.json
@@ -30,7 +30,7 @@
   },
   "dependencies": {
     "@babel/runtime": "7.13.10",
-    "adaptivecards": "2.5.0",
+    "adaptivecards": "2.9.0",
     "botframework-directlinejs": "0.14.1",
     "botframework-directlinespeech-sdk": "0.0.0-0",
     "botframework-webchat-api": "0.0.0-0",