CB-367: Review page doesn't link to the detail page of the entity.

[KasukabeDefenceForce]

CB-367

[alastair]

@brainzbot test this please

[alastair]

Thanks for these changes.
One thing that we like to do when making changes to these projects is to make sure that we leave the code in a better quality than when we started. This could mean things like improving tests, or removing code that's no longer required. I added some suggestions for things that we could do to improve the structure of this code to make this better.

[alastair]

This is much better, thanks. Just a few small things to update

[alastair]

Thanks for making these changes. I see one more display issue in one of the templates. Can you double-check all of them that the show the link properly?

[KasukabeDefenceForce]

@alastair Tests for this PR are passing offline but not online. Please take a look.

[alastair]

@brainzbot test this please

[alastair]

@AbhinavOhri I found the failing tests, and fixed them in #322, we can merge those fixes here once we approve that PR.

How are you running the tests? I realised that ./develop.sh test may give the wrong results sometimes. Try with

./test.sh -d
./test.sh

and see if you get the failures

[KasukabeDefenceForce]

https://gist.github.com/AbhinavOhri/020de79a735721b22cee423bbd479abf
I rebased my current branch on the latest master but I am still facing the same errors.I dont think they are related to my PR.

[amCap1712]

Updated the PR. Did some reformatting and added a missing link.

[github-actions]

Unit Test Results

    1 files  ±0      1 suites  ±0   44s ⏱️ ±0s
145 tests ±0  145 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 5b07c68. ± Comparison against base commit 5b07c68.