Added hyperlink to the review page

metabrainz · Oct 17, 2020 · d211c8b · d211c8b
1 parent d1c1c17
commit d211c8b
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 6 deletions.
diff --git a/critiquebrainz/frontend/templates/review/modify/artist.html b/critiquebrainz/frontend/templates/review/modify/artist.html
@@ -1,11 +1,11 @@
 {% if entity is not defined %}
-  {% set entity = review.entity_id | entity_details(type=entity_type) %}
+  {% set entity = entity_id | entity_details(type=entity_type) %}
 {% endif %}
 <div class="col-md-12">
   <dl class="dl-horizontal">
     <dt>{{ _('Artist') }}</dt>
     <dd>
-      {{ entity['name'] | default(_('[Unknown artist]')) }}
+      <a href="{{ url_for('artist.entity', mbid=entity_id) }}" target="_blank">{{entity['name'] | default(_('[Unknown artist]')) }}</a>
     </dd>
     <dt>{{ _('Type') }}</dt>
     <dd>{{ entity['type'] or '-' }}</dd>

diff --git a/critiquebrainz/frontend/templates/review/modify/event.html b/critiquebrainz/frontend/templates/review/modify/event.html
@@ -6,6 +6,7 @@
     <dt>{{ _('Event') }}</dt>
     <dd>
       {{ entity['name'] | default(_('[Unknown event]')) }}
+       <a href="{{ url_for('event.entity', id=entity_id) }}" target="_blank">{{ entity['name'] | default(_('[Unknown event]')) }}</a>
       {% if entity['life-span'] %}
         <span class="text-muted">({{ entity['life-span']['begin'] }} - {{ entity['life-span']['end'] }})</span>
       {% endif %}

diff --git a/critiquebrainz/frontend/templates/review/modify/label.html b/critiquebrainz/frontend/templates/review/modify/label.html
@@ -5,7 +5,7 @@
   <dl class="dl-horizontal">
     <dt>{{ _('Label') }}</dt>
     <dd>
-      {{ entity['name'] | default(_('[Unknown label]')) }}
+       <a href="{{ url_for('label.entity', id=entity_id) }}" target="_blank">{{ entity['name'] | default(_('[Unknown label]')) }}</a>
       {% if entity['life-span'] %}
         <span class="text-muted">({{ entity['life-span']['begin'] }} - {{ entity['life-span']['end'] }})</span>
       {% endif %}

diff --git a/critiquebrainz/frontend/templates/review/modify/place.html b/critiquebrainz/frontend/templates/review/modify/place.html
@@ -6,6 +6,7 @@
     <dt>{{ _('Place') }}</dt>
     <dd>
       {{ entity['name'] | default(_('[Unknown place]')) }}
+    <a href="{{ url_for('place.entity', id=entity_id) }}" target="_blank">{{ entity['name'] | default(_('[Unknown place]')) }}</a>
       {% if entity['life-span'] %}
         <span class="text-muted">({{ entity['life-span']['begin'] }} - {{ entity['life-span']['end'] }})</span>
       {% endif %}

diff --git a/critiquebrainz/frontend/templates/review/modify/release_group.html b/critiquebrainz/frontend/templates/review/modify/release_group.html
@@ -8,7 +8,7 @@
     <dt>{{ _('Artist') }}</dt><dd>{{ entity['artist-credit-phrase'] | default(_('[Unknown artist]')) }}</dd>
     <dt>{{ _('Release group') }}</dt>
     <dd>
-      {{ entity['title'] | default(_('[Unknown release group]')) }}
+       <a href="{{ url_for('release_group.entity', id=entity_id) }}" target="_blank">{{ entity['title'] | default(_('[Unknown release group]')) }}</a>
       {% if entity['first-release-date'] %}
         <span class="text-muted">({{ entity['first-release-date'][:4] }})</span>
       {% endif %}

diff --git a/critiquebrainz/frontend/templates/review/modify/work.html b/critiquebrainz/frontend/templates/review/modify/work.html
@@ -6,6 +6,7 @@
     <dt>{{ _('Work') }}</dt>
     <dd>
       {{ entity['name'] | default(_('[Unknown work]')) }}
+         <a href="{{ url_for('work.entity', id=entity_id) }}" target="_blank">{{entity['name'] | default(_('[Unknown work]')) }}</a>
     </dd>
     <dt>{{ _('Type') }}</dt>
     <dd>{{ entity['type'] or '-' }}</dd>

diff --git a/critiquebrainz/frontend/views/review.py b/critiquebrainz/frontend/views/review.py
@@ -278,7 +278,7 @@ def create(entity_type=None, entity_id=None):
         if not form.errors:
             flash.info(gettext("Please provide some text or a rating for this review."))
         return render_template('review/modify/write.html', form=form, entity_type=entity_type, entity=entity,
-                               spotify_mappings=spotify_mappings, soundcloud_url=soundcloud_url)
+                               entity_id=entity_id, spotify_mappings=spotify_mappings, soundcloud_url=soundcloud_url)
 
     entity_title = None
     if 'title' in entity:
@@ -289,7 +289,7 @@ def create(entity_type=None, entity_id=None):
     if not form.errors:
         flash.info(gettext("Please provide some text or a rating for this review."))
     return render_template('review/modify/write.html', form=form, entity_type=entity_type,
-                           entity_title=entity_title, entity=entity)
+                           entity_title=entity_title, entity=entity, entity_id=entity_id)
 
 
 @review_bp.route('/<uuid:id>/edit', methods=('GET', 'POST'))