Skip to content

Commit

Permalink
Made the necessary changes from the code review
Browse files Browse the repository at this point in the history
  • Loading branch information
KasukabeDefenceForce authored and amCap1712 committed Feb 6, 2022
1 parent 34d8ffd commit 5f2a8eb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions critiquebrainz/frontend/templates/review/modify/artist.html
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<div class="col-md-12">
<dl class="dl-horizontal">
<dt>{{ _('Artist') }}</dt>
<dd>
<a href="{{ url_for('artist.entity', mbid=review.entity['id']) }}" target="_blank">{{ entity['name'] }}</a>
<dd>
<a href="{{ url_for('artist.entity', mbid=entity['id']) }}" target="_blank">{{ entity['name'] }}</a>
</dd>
<dt>{{ _('Type') }}</dt>
<dd>{{ entity['type'] or '-' }}</dd>
Expand Down
2 changes: 1 addition & 1 deletion critiquebrainz/frontend/views/review.py
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ def create(entity_type=None, entity_id=None):
if not form.errors:
flash.info(gettext("Please provide some text or a rating for this review."))
return render_template('review/modify/write.html', form=form, entity_type=entity_type,
entity_title=entity_title, entity=entity, entity_id=entity_id)
entity_title=entity_title, entity=entity)


@review_bp.route('/<uuid:id>/edit', methods=('GET', 'POST'))
Expand Down

0 comments on commit 5f2a8eb

Please sign in to comment.