This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Rename MEILI_MAX_MDB_SIZE env var and --max-mdb-size option flag #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curquiza
approved these changes
Jun 14, 2021
irevoire
reviewed
Jun 14, 2021
Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
curquiza
reviewed
Jun 14, 2021
Kerollmops
approved these changes
Jun 16, 2021
irevoire
approved these changes
Jun 16, 2021
gmourier
changed the title
gmourier
added
Ready To Be Implemented
gmourier
changed the title
gmourier
added
Implemented
gmourier
added a commit
that referenced
this pull request
Aug 17, 2021
* Intialize specification * Apply suggestions from code review Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com> * update specification * add 0.20 error description in specification file * remove 0.21 current state missing http error * update title and add date Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I. Summary
This specification is written to rename the
MEILI_MAX_MDB_SIZEenvironnement variable and--max-mdb-sizeoption flag toMEILI_MAX_INDEX_SIZEand--max-index-size.II. Motivation
Since version 0.21 no longer has a main LMDB database for all indexes but one LMBD database per index, the concept of a
maindatabase no longer exists internally.