Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Commit

Permalink
Rename MAX_MDB_SIZE env var and --max-mdb-size option flag (#48)
Browse files Browse the repository at this point in the history
* Intialize specification

* Apply suggestions from code review

Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>

* update specification

* add 0.20 error description in specification file

* remove 0.21 current state missing http error

* update title and add date

Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
  • Loading branch information
gmourier and curquiza committed Aug 17, 2021
1 parent 7fd331e commit 6caec71
Showing 1 changed file with 39 additions and 0 deletions.
39 changes: 39 additions & 0 deletions text/0048-rename-max-mdb-size-var.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
- Title: Rename MAX_MDB_SIZE env var and --max-mdb-size option flag
- Start Date: 2021-04-14
- Specification PR: [#48](https://github.com/meilisearch/specifications/pull/48)
- MeiliSearch Tracking-issues: [transplant/#206](https://github.com/meilisearch/transplant/issues/206)


# Rename MAX_MDB_SIZE env var and --max-mdb-size option flag

## 1. Functional Specification

### I. Summary

This specification is written to rename the `MAX_MDB_SIZE` environnement variable and `--max-mdb-size` option flag to `MAX_INDEX_SIZE` and `--max-index-size`.

### II. Motivation

Since version 0.21 no longer has a main LMDB database for all indexes but one LMBD database per index, the concept of a `main` database no longer exists internally.


### III. Additional Materials
N/A

### IV. Explanation

- Rename `--max-mdb-size` to `--max-index-size`
- Rename `MAX_MDB_SIZE` to `MAX_INDEX_SIZE`

### V. Impact on Documentation

- Update the [Max MDB Size documentation part](https://docs.meilisearch.com/reference/features/configuration.html#max-mdb-size).

### VI. Impact on SDKs
N/A

## 2. Technical Aspects
N/A

## 3. Future Possibilities
- Provide a way to set a custom size per index.

0 comments on commit 6caec71

Please sign in to comment.