Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Rename MEILI_MAX_MDB_SIZE env var and --max-mdb-size option flag #48

Merged
merged 6 commits into from
Jun 16, 2021
Merged

Rename MEILI_MAX_MDB_SIZE env var and --max-mdb-size option flag #48

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d5378c6
Intialize specification
gmourier Jun 14, 2021
a58f6ff
Apply suggestions from code review
gmourier Jun 14, 2021
feefd48
update specification
gmourier Jun 14, 2021
9aa07e3
add 0.20 error description in specification file
gmourier Jun 14, 2021
56a6ac9
remove 0.21 current state missing http error
gmourier Jun 15, 2021
262c50b
update title and add date
gmourier Jun 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions text/0048-rename-max-mdb-size-var.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,20 @@ N/A

### IV. Explanation

- Rename `--max-mdb-size` to `--max-index-size`
- Rename `MAX_MDB_SIZE` to `MAX_INDEX_SIZE`

- Rename `--max-mdb-size` to `--max-index-size`
- Rename `MAX_MDB_SIZE` to `MAX_INDEX_SIZE`
- Error handling at index creation should be iso with version 0.20.

When I test the current version of meilisearch in 0.21, the http call on `POST /indexes/:index_uid/documents` is successful and an empty index is created whereas 0.20 returns an error on the API side and the index is not created.
gmourier marked this conversation as resolved.
Show resolved Hide resolved

```
{
"message": "Impossible to create index; heed error; MDB_MAP_FULL: Environment mapsize limit reached",
"errorCode": "index_creation_failed",
"errorType": "internal_error",
"errorLink": "https://docs.meilisearch.com/errors#index_creation_failed"
}
```

### V. Impact on Documentation

Expand Down