Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sub story count cache column not up to date #4

Open
wants to merge 53 commits into
base: master
Choose a base branch
from

Conversation

geralddzx
Copy link

No description provided.

randycoulman and others added 30 commits May 4, 2015 11:34
We were checking `persisted?`, which is always true in an `after_save` callback.
shirish-pampoorickal and others added 23 commits July 7, 2015 12:17
…butes that needs updating when ancestry changes
Add option to enable `root_ancestor` relation
…el_stories

Update root_ancestor_id of descendants when parent is made a root
The current behavior is that a new record will have all stories in the entire database as descendants

- Rick and Gerald
@mdub
Copy link
Owner

mdub commented Jan 27, 2017

Wow ... that is quite the PR!

Looks like you folks have been using and improving arboreal for a couple of years. I'd like to merge in your work, but there's simply too much going on here for me to review. I note there are also a few commits that alter behaviour, without accompanying tests.

Could you break your fork into separate PRs, so we can look at merging it incrementally?

@mkllnk mkllnk mentioned this pull request Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants