Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sub story count cache column not up to date #4

Open
wants to merge 53 commits into
base: master
Choose a base branch
from
Open

Fix sub story count cache column not up to date #4

wants to merge 53 commits into from

Conversation

geralddzx
Copy link

No description provided.

randycoulman and others added 30 commits May 4, 2015 11:34
@randycoulman
Get specs passing with rspec 2.10
2ac9319
@randycoulman
Run with ActiveRecord 3 only
90578c0
@randycoulman
Use new Rspec Rake task and newer bundler gem tasks
d521637
@randycoulman
Remove Rails 2 references; bump verison to 0.3.0
c48447e
@randycoulman
Update minimum Ruby version; using new hash syntax
1436088
@randycoulman
Split tests and spec_helper into separate files
f5068a1
@randycoulman
Allow children relation options to be specified
8a6fb6c
@randycoulman
Protect ancestry_string against sql injection and ancestry_string for…
b33071d 
…matting errors
@randycoulman
Rename ancestry_string -> materialized_path
c353fbf
@randycoulman
Better handle hierarchies of unsaved objects
35db478
@randycoulman
Handle the case where a child's parent is changing to an unsaved node
dc7ab5b
@randycoulman
Don't allow a null materialized_path to be persisted
77551dc
@randycoulman
Only apply ancestry changes to children after an update, not a create
ea0bb3a 
We were checking `persisted?`, which is always true in an `after_save` callback.
@randycoulman
Minor cleanups and new specs
8905cab
@randycoulman
Allow the parent relation to be customized
61894bc
@randycoulman
Add relation customization documentation to the README
17e0c13
@randycoulman
Remove support for AR 3.0
d4d1c20
@randycoulman
Update AR dependency in the gemspec to 3.1
18e4d9d
@randycoulman
Keep ancestor_ids from erroring on a newly-created model
2bee717
@randycoulman
Arboreal models now understand root?
ce78ccf
@randycoulman
Optimize root by taking advantage of new root? method
559ce5e
@randycoulman
Merge pull request #1 from mavenlink/mavenlink_upgrades
4e0abee 
Mavenlink upgrades
@randycoulman
Add an ancestry_depth query
7f2e03e
@CacheFactory
remove with_exclusive_scope
32384cd
@CacheFactory
travis should build the 4.1 version
76de42d
@CacheFactory
inverse_of was breaking cache clearing behavior
02817e2
@CacheFactory
fix another rails4 issue; add back inverses and use parent_id presenc…
766d7c6 
…e check
Adding check for parent when populating materialized path
207b4e7
@CacheFactory
Merge pull request #2 from mavenlink/add_ancestry_depth
b4dfe89 
Add an ancestry_depth query
@naiyt
Merge branch 'master' into rails4
eb305a9
shirish-pampoorickal and others added 23 commits July 7, 2015 12:17
@shirish-pampoorickal
Add Branch model which does not include foreign key for root rela…
11b128c 
…tion
@shirish-pampoorickal
Add foreign key for root relation to Node model
d245238
@shirish-pampoorickal
Updated extension to allow configuring optional root_ancestor relation
312a46d
@shirish-pampoorickal
Updated rebuild_ancestry to re-populate the foreign key for the `ro…
024cb0e 
…ot_ancestor` association if enabled
@shirish-pampoorickal
Bumped rspec gem version to 2.13.0
c788145
@shirish-pampoorickal
Updated instance methods to look at root_ancestry relation when ena…
a522439 
…bled
@shirish-pampoorickal
Bumped SQLite gem version
23d9ed5
@shirish-pampoorickal
Implemented descendant_attributes_to_update which derives the attri…
48fd0ec 
…butes that needs updating when ancestry changes
@shirish-pampoorickal
Fixed Sqlite issues with updating root_ancestor_id
9ca8ef4
@shirish-pampoorickal
Updated populate_root_relation to use direct SQL only for MySQL
4a9d374
@shirish-pampoorickal
Reverted rspec & sqlite3 gem versions. Updated specs to work with rsp…
3afdf2a 
…ec-2.10.0
@shirish-pampoorickal
Fixed formatting issue
2269d14
@shirish-pampoorickal
Replace unnecessary gsub with sub
4807c24
@shirish-pampoorickal
Updated root method as per code review
8fb9ccf
Merge remote-tracking branch 'origin/add_optional_root_relation' into…
54cbd39 
… rails4
removes with_exclusive_scope
ae0f04c
@shirish-pampoorickal
Fixed failures on ActiveRecord-4.1.12
a6729ad
Merge pull request #4 from mavenlink/add_optional_root_relation
0706a84 
Add option to enable `root_ancestor` relation
@naiyt
Merge pull request #3 from mavenlink/rails4
26409fc 
Rails4 Compatability
@shirish-pampoorickal
Fixed issue with root_ancestor_id of descendants being set as nil whe…
0c0741c 
…n a child node is made a root
@shirish-pampoorickal
Updated spec to use map instead of pluck to be compatible with Active…
d3bdaa8 
…Record-3.1 in Ruby 1.9.3
Merge pull request #5 from mavenlink/fix_ancestry_depth_for_multi_lev…
b605aec 
…el_stories

Update root_ancestor_id of descendants when parent is made a root
@geralddzx
A new record should not have descendants
f094f44 
The current behavior is that a new record will have all stories in the entire database as descendants

- Rick and Gerald
@mdub
Copy link
Owner

mdub commented Jan 27, 2017

Wow ... that is quite the PR!

Looks like you folks have been using and improving arboreal for a couple of years. I'd like to merge in your work, but there's simply too much going on here for me to review. I note there are also a few commits that alter behaviour, without accompanying tests.

Could you break your fork into separate PRs, so we can look at merging it incrementally?

@mkllnk mkllnk mentioned this pull request Jun 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@geralddzx @mdub @naiyt @shirish-pampoorickal @randycoulman @CacheFactory