Mavenlink upgrades #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were checking `persisted?`, which is always true in an `after_save` callback.
|
Also need to:
|
|
I added Travis, maybe we need to re-push this? |
|
Closing and re-opening to kick the Travis build |
|
I don't think we should commit the .pairs file publicly. We can add a global one to ansible, but for now, please remove and force push. |
randycoulman
force-pushed
the
mavenlink_upgrades
branch
from
5a8c95e to
18e4d9d
Compare
|
|
||
| class Thing < ActiveRecord::Base | ||
|
|
||
| acts_arboreal parent_relation_options: { touch: true }, children_relation_options: { autosave: true } |
|
@cantino Can we get a final LGTM on this? |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fairly large PR that contains a number of upgrades that @cantino made to this somewhat outdated gem:
ancestry_stringtomaterialized_pathto avoid confusion with the ancestry gem@bobby1190 @shirish-pampoorickal: Can you look this over and see what you think?