Rails4 Compatability #3
Conversation
|
LGTM! |
|
@shirish-pampoorickal Do you have any idea why |
|
@shirish-pampoorickal @cantino @urnf We had tests on Rails 4 failing due to the fact that Please ensure that this expectation is correct since we are changing it slightly. We've added a test for it. |
|
@shirish-pampoorickal Opinion on this? |
|
@shirish-pampoorickal @cantino Anyone opposed to merging this? |
| model_base_class.send(:with_exclusive_scope) do | ||
| self.materialized_path = parent ? parent.path_string : "-" | ||
| end | ||
| self.materialized_path = (parent_id && parent) ? parent.path_string : "-" |
There was a problem hiding this comment.
Is it possible for parent to exist but not have parent_id, such as during object building with new records?
|
I'm out next week -- @shirish-pampoorickal owns this. |
|
Go ahead and merge, and maybe only bump Gemfile in rails 4? |
|
@naiyt Let's merge but not bump on master, only on rails 4. |
|
Sounds good to me. |
|
Ok, since the branch is deleted, be sure to bundle update on rails4. |
@shirish-pampoorickal @randycoulman @urnf
It's not clear to be why we would need
unscoped/with_exclusive_scopeonparent.